View Widget View handler #8135
Open
View Widget View handler #8135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BurningTreeC
added a commit
to BurningTreeC/TiddlyWiki5
that referenced
this pull request
Apr 6, 2024
|
Thanks @BurningTreeC I am just linking this back to the earlier discussion in #8125. Sorry for the delay. I am now a bit concerned that this is a lot of complexity to introduce in order to be able to attempt the optimisation proposed in #8105. However, I am not sure that at this point we have confidence that the eventual performance improvements will be worthwhile. Does this PR as it stand give you enough material to be able to explore the performance impact on #8105? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ViewHandlerbase class to theviewwidget andsubclassesfor each of the different viewsThe
ViewHandlerhas methodsrender,renderWikified,createTextNode,createWikifiedTextNode,createFakeWidgetandrefresh- EDIT: and now alsorefreshWikifiedThese methods are used by more than one of the different subclasses.
The subclasses are initialised if they're needed.
There's still a big
switchstatement in theViewWidget'sgetViewmethod to find the view and initialise the correct subclass, maybe there's a better method to do so but I haven't found one.Each subclass has its own
getValuemethod.The wikified views also have dedicated
renderandrefreshmethods.I hope I got this right this time 😸
Please review and test and leave me some comments if this is the right approach and what could be simplified.
I had to read about subclassing for this and am not 100% sure if I got it right.