Fix memory leak in UpdateEffect #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are animations on the screen, after some time we will encounter performance degradation, and an increased memory consumption. This fix is similar to the other fix in the past (https://android-review.googlesource.com/c/platform/frameworks/support/+/1398690). We have to remember the lambda instead of creating it each time. Fixes JetBrains/compose-multiplatform#2455 Fixes JetBrains/compose-multiplatform#1969 The tests are not very deterministic, but it seems better to have them than not to have. The second test fails before the fix, and passes after the fix. We will see if they will be stable on our CI or not. If they will be flaky, we will tune them, or remove them.
eymar
approved these changes
Nov 10, 2022
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
If there are animations on the screen, after some time we will encounter performance degradation, and an increased memory consumption. This fix is similar to the other fix in the past (https://android-review.googlesource.com/c/platform/frameworks/support/+/1398690). We have to remember the lambda instead of creating it each time. Fixes JetBrains/compose-multiplatform#2455 Fixes JetBrains/compose-multiplatform#1969 The tests are not very deterministic, but it seems better to have them than not to have. The second test fails before the fix, and passes after the fix. We will see if they will be stable on our CI or not. If they will be flaky, we will tune them, or remove them.
igordmn
added a commit
that referenced
this pull request
Dec 5, 2022
If there are animations on the screen, after some time we will encounter performance degradation, and an increased memory consumption. This fix is similar to the other fix in the past (https://android-review.googlesource.com/c/platform/frameworks/support/+/1398690). We have to remember the lambda instead of creating it each time. Fixes JetBrains/compose-multiplatform#2455 Fixes JetBrains/compose-multiplatform#1969 The tests are not very deterministic, but it seems better to have them than not to have. The second test fails before the fix, and passes after the fix. We will see if they will be stable on our CI or not. If they will be flaky, we will tune them, or remove them.
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
If there are animations on the screen, after some time we will encounter performance degradation, and an increased memory consumption. This fix is similar to the other fix in the past (https://android-review.googlesource.com/c/platform/frameworks/support/+/1398690). We have to remember the lambda instead of creating it each time. Fixes JetBrains/compose-multiplatform#2455 Fixes JetBrains/compose-multiplatform#1969 The tests are not very deterministic, but it seems better to have them than not to have. The second test fails before the fix, and passes after the fix. We will see if they will be stable on our CI or not. If they will be flaky, we will tune them, or remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are animations on the screen, after some time we will encounter performance degradation, and increased memory consumption.
This fix is similar to the other fix in the past (https://android-review.googlesource.com/c/platform/frameworks/support/+/1398690). We have to remember the lambda instead of creating it each time.
Fixes JetBrains/compose-multiplatform#2455
Fixes JetBrains/compose-multiplatform#1969
The tests are not very deterministic, but it seems better to have them than not to have. The second test fails before the fix, and passes after the fix.
We will see if they will be stable on our CI or not. If they will be flaky, we will tune them, or remove them.
P.S. the code of the test's application (everything above
AppWindow) is just copied from the run1 example