Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in UpdateEffect #325

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fix memory leak in UpdateEffect #325

merged 1 commit into from
Nov 10, 2022

Commits on Nov 10, 2022

  1. Fix memory leak in Update effects 

    If there are animations on the screen, after some time we will encounter performance degradation, and an increased memory consumption.

This fix is similar to the other fix in the past (https://android-review.googlesource.com/c/platform/frameworks/support/+/1398690). We have to remember the lambda instead of creating it each time.

Fixes JetBrains/compose-multiplatform#2455
Fixes JetBrains/compose-multiplatform#1969

The tests are not very deterministic, but it seems better to have them than not to have. The second test fails before the fix, and passes after the fix.
We will see if they will be stable on our CI or not. If they will be flaky, we will tune them, or remove them.
    @igordmn
    igordmn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    ce6c382 View commit details
    Browse the repository at this point in the history