WB-1675: Implement Combobox component with single selection #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7554bcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1.36 kB (+1.41%) Total Size: 97.8 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-seiomgwdex.chromatic.com/ Chromatic results:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
==========================================
+ Coverage 94.48% 94.72% +0.23%
==========================================
Files 248 249 +1
Lines 29268 29736 +468
Branches 1638 2447 +809
==========================================
+ Hits 27654 28166 +512
+ Misses 1610 1543 -67
- Partials 4 27 +23
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (8b29604) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2221"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2221 |
jeresig
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first PR associated to the Combobox implementation. It includes the
basic structure of the Combobox component with single selection support.
Combobox Implementation Plan:
Listboxcomponent with Single and Multiple selection support #2216Comboboxcomponent with Single selection support. [CURRENT]Comboboxcomponent.Comboboxcomponent.Comboboxcomponent.Issue: https://khanacademy.atlassian.net/browse/WB-1675
Test plan:
Verify that the new
Componentcomponent works as expected and that the newdocumentation is accurate.
/?path=/docs/packages-dropdown-combobox--docs
https://5e1bf4b385e3fb0020b7073c-mzmurnrasq.chromatic.com/?path=/docs/packages-dropdown-combobox--docs
Keyboard navigation:
ArrowDown / ArrowUpkeys to navigate through the options.Enterkey to select an option.Escapekey to close the Listbox.Screen.Recording.2024-05-01.at.3.10.07.PM.mov