Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accepting file containing test files to run - add support for env var KNAPSACK_TEST_FILE_LIST_SOURCE_FILE #103

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

alexanderjeurissen
Copy link

ref: KnapsackPro/knapsack_pro-ruby#129

This PR adds support for this behavior to the regular knapsack gem.

@alexanderjeurissen alexanderjeurissen changed the title Allow accepting file containing test files to run - add support for env var KNAPSACK_TEST_FILE_LIST_SOURCE_FILE WIP: Allow accepting file containing test files to run - add support for env var KNAPSACK_TEST_FILE_LIST_SOURCE_FILE Mar 21, 2021
@alexanderjeurissen alexanderjeurissen changed the title WIP: Allow accepting file containing test files to run - add support for env var KNAPSACK_TEST_FILE_LIST_SOURCE_FILE Allow accepting file containing test files to run - add support for env var KNAPSACK_TEST_FILE_LIST_SOURCE_FILE Mar 21, 2021
@alexanderjeurissen
Copy link
Author

@ArturT Any chance of this getting merged in upstream ?

@ArturT
Copy link
Member

ArturT commented Apr 18, 2021

Hi @alexanderjeurissen

This feature is specific to the knapsack_pro version. More about it here https://knapsackpro.com/faq/question/how-to-run-a-specific-list-of-test-files-or-only-some-tests-from-test-file

Support from users who use the knapsack_pro gem helps us keep maintaining the project and provide ongoing support for the users.

At the moment we have a pretty busy time with other priorities so we haven't decided yet whether to introduce the same feature into the knapsack gem. We might revisit this PR later.

If you like you can try out the knapsack_pro gem version in the meantime and we can help with the setup. If you have an open-source project then you can use it for free. Feel free to contact us. We can always find a win-win solution for your team and provide technical tips on how to improve your CI setup.

Cheers

@wscourge
Copy link

@ArturT how is it going with the decision?

@ArturT
Copy link
Member

ArturT commented Dec 16, 2022

@wscourge At this moment, we abstain from the decision to introduce new features.

I hope in 2023, we will clarify the high-level plans so that we can put more focus on delivering value to users. We will better understand how the knapsack gem fits into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants