conformance: add support for GRPCRoute #5776
Open
+70
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao12345666333
added
the
kind/conformance
most of these tests have failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5776 +/- ##
======================================
Coverage ? 73.6%
======================================
Files ? 193
Lines ? 18814
Branches ? 0
======================================
Hits ? 13848
Misses ? 4005
Partials ? 961 ☔ View full report in Codecov by Sentry. |
tao12345666333
force-pushed
the
grpcroute-conformance
branch
from
91ff3ed
to
a04d32a
Compare
tao12345666333
force-pushed
the
grpcroute-conformance
branch
3 times, most recently
from
9d514ca
to
91d2c60
Compare
tao12345666333
force-pushed
the
grpcroute-conformance
branch
from
3257481
to
fa23b77
Compare
tao12345666333
force-pushed
the
grpcroute-conformance
branch
from
fa23b77
to
7bc9b8e
Compare
|
Blocked by #5918 |
tao12345666333
force-pushed
the
grpcroute-conformance
branch
from
7bc9b8e
to
502847c
Compare
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
grpcroute-conformance
branch
from
ed43c24
to
1c6a1cb
Compare
|
For |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
randmonkey
reviewed
May 20, 2024
| @@ -82,6 +82,10 @@ func TestMain(m *testing.M) { | |||
| kongBuilder = kongBuilder.WithProxyEnvVar("router_flavor", string(dpconf.RouterFlavorExpressions)) | |||
| } | |||
|
|
|||
| // The test cases for GRPCRoute in the current GatewayAPI all use the h2c protocol. | |||
| // In order to pass conformance tests, the proxy must listen http2 and http on the same port. | |||
| kongBuilder.WithProxyEnvVar("PROXY_LISTEN", `0.0.0.0:8000 http2\, 0.0.0.0:8443 http2 ssl`) | |||
There was a problem hiding this comment.
Is there any reason to add a \ to escape the ,?
| @@ -24,7 +24,8 @@ const ( | |||
| // GRPCBinImage is the container image name we use for deploying the "grpcbin" GRPC testing tool. | |||
| // See: https://github.com/Kong/grpcbin | |||
| GRPCBinImage = "kong/grpcbin:latest" | |||
| GRPCBinPort = 9001 | |||
| GRPCBinPort = 9000 | |||
| GRPCSBinPort = 9001 | |||
There was a problem hiding this comment.
This GRPCSBinPort seems not be refefenced anywhere now. Also, in test/integration/isolated/ingress_test.go, the test/consts package is imported but it did not use the constants for defining ports for grpc services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
fixes: #5705
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR