Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump GWAPI v1.1 and support for GRPCRoute v1 #5918

Merged
merged 6 commits into from
May 11, 2024
Merged

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Apr 25, 2024

What this PR does / why we need it:

  • Bump GWAPI to v1.1
  • Add support for GRPCRoute v1

Which issue this PR fixes:

fixes: #5960

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

go.mod Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member Author

Blocked by #5935

@tao12345666333 tao12345666333 self-assigned this Apr 25, 2024
@tao12345666333 tao12345666333 added this to the KIC v3.2.x milestone Apr 25, 2024
@tao12345666333 tao12345666333 linked an issue Apr 25, 2024 that may be closed by this pull request
4 tasks
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.8%. Comparing base (3017d33) to head (307bfdb).
Report is 3 commits behind head on main.

❗ Current head 307bfdb differs from pull request most recent head c7b36a6. Consider uploading reports for the commit c7b36a6 to get more accurate results

Files Patch % Lines
...ternal/controllers/gateway/grpcroute_controller.go 50.0% 2 Missing ⚠️
internal/dataplane/kongstate/upstream.go 0.0% 1 Missing ⚠️
internal/store/fake_store.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5918     +/-   ##
=======================================
- Coverage   72.8%   68.8%   -4.0%     
=======================================
  Files        182     182             
  Lines      18344   18345      +1     
=======================================
- Hits       13361   12628    -733     
- Misses      4056    4800    +744     
+ Partials     927     917     -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tao12345666333 tao12345666333 changed the title feat: add support for GRPCRoute v1 feat: bump GWAPI v1.1 and support for GRPCRoute v1 May 10, 2024
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 marked this pull request as ready for review May 11, 2024 00:47
@tao12345666333 tao12345666333 requested a review from a team as a code owner May 11, 2024 00:47
@tao12345666333 tao12345666333 added the ci/run-e2e Trigger e2e test run from PR label May 11, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9040214047

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label May 11, 2024
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@randmonkey randmonkey merged commit d8c30ad into main May 11, 2024
36 checks passed
@randmonkey randmonkey deleted the grpcroute-v1 branch May 11, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPCRoute conformance Bump Gateway API to v1.1
4 participants