Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to exclude classes / packages by Regex pattern #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikepenz
Copy link

The pull request introduced a new configuration option ignored.

ignored takes an array of regex patterns to exclude whole packages and classes based on this pattern. This configuration can be provided alongside the already existing ignoredPackages and ignoredClasses and offers much greater flexibility on ignoring sources from being included in the validation.

Motivation

The current offered APIs require absolute package names and class names, making very verbose for large projects.
Additionally the nonPublicMarkers would be great for these situations, but we can not attach them to generated sources from plugins, which we have no control over.

Using the regex provides much higher flexibility and it is possible to for example exclude all packages including /internal/ in their package name.

Or similar all generated classes by Androids navigation plugin which end in com.company.MyFragmentDirections

@mikepenz mikepenz changed the title Support to exclude classes / packages by Regex pattern Support to exclude classes / packages by Regex pattern Feb 24, 2023
@qwwdfsad qwwdfsad self-requested a review February 24, 2023 15:17
@qwwdfsad
Copy link
Member

Thanks!

There is currently a big rework with help of @aSemy, I'll get back to this PR as soon as the work with the plugin itself is done

@mikepenz
Copy link
Author

Thank you very much @qwwdfsad for the update. Happy to rebase and resolve conflicts on this after those reworks were done. (in case the PR is still relevant afterwards)

@RingerJK
Copy link

@qwwdfsad can the PR be moved forward?

@mikepenz
Copy link
Author

It probably has to be re-created now given the time since it was created. I was waiting until the big rework happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants