Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose core test types properly #1087

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Commits on May 2, 2024

  1. chore(node, core): move LavaMoatOpts typedef into lavamoat-core

    this removes the implicit dependency on `lavamoat` from `lavamoat-core`
    boneskull committed May 2, 2024
    Copy the full SHA
    d5d5522 View commit details
    Browse the repository at this point in the history
  2. chore(core): expose types from test/util and scenario definition

    In order for other packages to consume the types from `test/util.js` (and the `Scenario` type), `lavamoat-core` needs to generate `.d.ts` files.  To do this, I:
    
    1. Moved `test/scenarios/scenario.d.ts` (which is not typechecked!) to `test/scenario.ts` (which is)
    2. Changed `test/tsconfig.json` to output declarations (instead of nothing) for both `test/util.js` and `test/scenario.ts`
    3. Update `test/util.js` with the new location of the `scenario` module (and fix a type problem I found)
    boneskull committed May 2, 2024
    Copy the full SHA
    e8d004c View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    afb79b5 View commit details
    Browse the repository at this point in the history