expose core test types properly #1087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
force-pushed
the
boneskull/expose-core-types
branch
from
1a1ef98
to
d501be1
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates on |
|
A thing that sucks is the auto-label tool only detects additions and modifications--not deletions. |
boneskull
force-pushed
the
boneskull/expose-core-types
branch
4 times, most recently
from
bb9cd67
to
97a69e9
Compare
boneskull
changed the base branch from
main
to
boneskull/zap-aa-macos-perf-test
This was referenced Mar 19, 2024
boneskull
force-pushed
the
boneskull/zap-aa-macos-perf-test
branch
from
166c953
to
8fcab2f
Compare
boneskull
force-pushed
the
boneskull/expose-core-types
branch
from
97a69e9
to
f8f2ee2
Compare
boneskull
force-pushed
the
boneskull/expose-core-types
branch
from
f8f2ee2
to
ecda444
Compare
This was referenced Mar 20, 2024
boneskull
force-pushed
the
boneskull/expose-core-types
branch
4 times, most recently
from
72279ff
to
bd55e73
Compare
this removes the implicit dependency on `lavamoat` from `lavamoat-core`
In order for other packages to consume the types from `test/util.js` (and the `Scenario` type), `lavamoat-core` needs to generate `.d.ts` files. To do this, I: 1. Moved `test/scenarios/scenario.d.ts` (which is not typechecked!) to `test/scenario.ts` (which is) 2. Changed `test/tsconfig.json` to output declarations (instead of nothing) for both `test/util.js` and `test/scenario.ts` 3. Update `test/util.js` with the new location of the `scenario` module (and fix a type problem I found)
boneskull
force-pushed
the
boneskull/expose-core-types
branch
from
bd55e73
to
1b5299b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the types added in #651 to consumers (including our own packages). This is necessary for any package to use types like
Scenario.Of note, I moved the
LavaMoatOptstype intolavamoat-core, because that type is used directly by theScenariotype. This will avoid an implicit cycle inlavamoat-core&lavamoat.n/no-extraneous-*from touching test files with .ts extensions