Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove circular ref to ambient.ts #1127

Merged
merged 1 commit into from Mar 25, 2024
Merged

fix(core): remove circular ref to ambient.ts #1127

merged 1 commit into from Mar 25, 2024

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Mar 21, 2024 •
edited

This causes a cycle as detected by dependency-cruiser

Extracted from #820

@boneskull
fix(core): remove circular ref to ambient.ts
5dd61c6 
This causes a cycle as detected by dependency-cruiser
@boneskull boneskull requested a review from a team as a code owner March 21, 2024 17:55
@boneskull boneskull mentioned this pull request Mar 21, 2024
Open
@github-actions github-actions bot added the pkg:lavamoat-core Changes in package lavamoat-core label Mar 21, 2024
@naugtur naugtur merged commit b370419 into main Mar 25, 2024
19 checks passed
@naugtur naugtur deleted the boneskull/core-cycle-fix branch March 25, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naugtur naugtur naugtur approved these changes

Assignees

@boneskull boneskull

Labels
pkg:lavamoat-core Changes in package lavamoat-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boneskull @naugtur