chore: remove depcheck #820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates on |
|
An "orphan" is a file that isn't referenced by any other file. I think we can create exceptions for many of these esp in core |
|
also I neglected to run any tests so I'm not surprised I broke it |
boneskull
force-pushed
the
boneskull/depcruise
branch
from
bfb0fd8
to
a70cfdc
Compare
|
OK, I've got it down to a single warning. ❯ npm run lint:deps
> lavamoat-monorepo@0.0.0 lint:deps
> depcruise -c ./.config/dependency-cruiser.js packages scripts
info optional-deps-used: packages/node/test/prepare.js → node_modules/corepack/package.json
warn no-orphans: packages/tofu/src/referenceTracker.js
✘ 2 dependency violations (0 errors, 1 warnings). 339 modules, 574 dependencies cruised.This orphan file ( |
|
"2 dependency violations" is rather misleading, since the first one is not a violation at all. |
boneskull
force-pushed
the
boneskull/depcruise
branch
2 times, most recently
from
375697a
to
268aab4
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
5 times, most recently
from
b932edb
to
4144cbb
Compare
This was referenced Jan 4, 2024
boneskull
force-pushed
the
boneskull/depcruise
branch
from
4144cbb
to
94f5e4c
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
4 times, most recently
from
7ade82f
to
f7e9092
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
from
f7e9092
to
642284e
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/depcheck@1.4.7 |
boneskull
force-pushed
the
boneskull/depcruise
branch
2 times, most recently
from
bb20afd
to
9bdc0e5
Compare
This was referenced Mar 21, 2024
boneskull
force-pushed
the
boneskull/issue1103
branch
from
e51063e
to
25a65b4
Compare
naugtur
force-pushed
the
boneskull/issue1103
branch
from
25a65b4
to
7c0dce2
Compare
boneskull
force-pushed
the
boneskull/issue1103
branch
from
7c0dce2
to
69d96e4
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
from
9bdc0e5
to
d5d4a3c
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
2 times, most recently
from
d76bb3c
to
bed4301
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
from
bed4301
to
7ec24e4
Compare
boneskull
force-pushed
the
boneskull/depcruise
branch
from
7ec24e4
to
fdc7d1c
Compare
This adds [dependency-cruiser](https://npm.im/dependency-cruiser) to replace [depcheck](https://npm.im/depcheck), which does a _very_ thorough check of all referenced packages throughout the codebase. To support this, I needed to create quite a few exceptions, as we often reference non-existent packages in our tests.
boneskull
force-pushed
the
boneskull/depcruise
branch
from
fdc7d1c
to
58e066b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds dependency-cruiser to replace depcheck, which does a very thorough check of all referenced packages throughout the codebase.
After configuration, I went through and fixed the problems it highlighted (of which there were many).
Closes #793
Reviewers
You'll want to look at everything here, as there were numerous problems. Hopefully I split it up in a way that makes sense.