Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Startup LL Desktop #5072

Merged
merged 8 commits into from Oct 24, 2023
Merged

Improve Startup LL Desktop #5072

merged 8 commits into from Oct 24, 2023

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 13, 2023 •
edited

📝 Description

This PR introduces:

  • Lazy Load Route components
  • Custom esbuild plugin to extract json files from src
  • Update targets to current env (node / browser)

Regarding flaky tests, this PR fix:

  • The main account was not correctly set, and multiple flows were impacted, this is fixed.
  • Flaky tests with dropdown hover state, fixed by moving the cursor out of the dropdown
  • Flaky test on swap fixed by waiting for the reverse to be done before opening the first dropdown

Improvements (on a Mac with M1):
Before (develop):

  • L: 4.75s
  • LCP: 7.09s
Screenshot 2023-10-18 at 15 25 12

After (support/extract-json):

  • L: 2.63s
  • LCP: 4.80s
Screenshot 2023-10-18 at 14 06 11

❓ Context

  • Impacted projects: lld
  • Linked resource(s): [https://ledgerhq.atlassian.net/browse/LIVE-9895]

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023 •
edited

🦋 Changeset detected

Latest commit: 77435da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 3:38pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 3:38pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 3:38pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 3:38pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 3:38pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 13, 2023
@KVNLS KVNLS changed the title Support/extract json Improve Startup LL Desktop Oct 16, 2023
@KVNLS KVNLS force-pushed the support/extract-json branch 8 times, most recently from e2c093f to 6709b8e Compare October 18, 2023 07:40
@KVNLS
Copy link
Member Author

KVNLS commented Oct 18, 2023 •
edited by live-github-bot bot

@KVNLS

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-mac
✅ - generate-screenshots-windows
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Oct 18, 2023
@KVNLS KVNLS force-pushed the support/extract-json branch 4 times, most recently from bc764b2 to 91c5034 Compare October 18, 2023 16:37
@vercel
Copy link

vercel bot commented Oct 18, 2023

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

@KVNLS KVNLS force-pushed the support/extract-json branch 3 times, most recently from ecba57b to 5db9cff Compare October 21, 2023 11:55
@KVNLS
Copy link
Member Author

KVNLS commented Oct 21, 2023 •
edited by live-github-bot bot

@KVNLS

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-mac
❌ - generate-screenshots-linux
❌ - generate-screenshots-windows

@KVNLS
Copy link
Member Author

KVNLS commented Oct 22, 2023

reduxjs/react-redux#1977

@KVNLS KVNLS force-pushed the support/extract-json branch 2 times, most recently from 23851d4 to 5c625b8 Compare October 23, 2023 08:35
@KVNLS
Copy link
Member Author

KVNLS commented Oct 23, 2023 •
edited by live-github-bot bot

@KVNLS

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux
❌ - generate-screenshots-windows
❌ - generate-screenshots-mac

@KVNLS
Copy link
Member Author

KVNLS commented Oct 23, 2023 •
edited by live-github-bot bot

@KVNLS

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux
✅ - generate-screenshots-mac
✅ - generate-screenshots-windows

@KVNLS KVNLS marked this pull request as ready for review October 23, 2023 16:12
@KVNLS KVNLS requested a review from a team October 23, 2023 16:12
@KVNLS KVNLS merged commit ff13a91 into develop Oct 24, 2023
30 of 32 checks passed
@KVNLS KVNLS deleted the support/extract-json branch October 24, 2023 09:00
@cgrellard-ledger cgrellard-ledger mentioned this pull request Nov 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valpinkman valpinkman valpinkman approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@KVNLS KVNLS

Labels
desktop Has changes in LLD screenshots Screenshots have been updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KVNLS @gre @valpinkman @mcayuelas-ledger