Bump browser build dependencies to Node 20 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnzxy
force-pushed
the
update-browserbuild-dependencies
branch
from
05041f9
to
73aaeb7
Compare
|
I have tested this version with Browser Build. I created a parallel PR to my loopdocs-tester organization (LoopWorkspace branch update) and ran the browser build for that branch.
The successful log file is here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the warning users currently see for browser build for node v16, i.e.
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.In accordance with GitHub Actions: Transitioning from Node 16 to Node 20, all actions must be using node version 20. Bumping the node version from v16 to v20 by using
aormsby/Fork-Sync-With-Upstream-action@v3.4.1(latest release see here) andactions/checkout@v4(which internally updated to node 20) as well asactions/upload-artifact@v4(internally uses node 20).