Fixes the remaining tests. #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…tes (open-telemetry#2576) * Replace recordingSpan attributes implementation Instead of an LRU strategy for cap-ing span attributes, comply with the specification and drop last added. To do this, the attributesmap is replaced with a slice of attributes. * Remove attributesmap files * Refine addition algorithm Unify duplicated code. Fix deduplication algorithm. Fix droppedAttributes to always be returned, even if the span has no attributes. * Unify span SetAttributes tests * Doc fix to attr drop order in changelog * Test span and snapshot attrs * fix lint * Add tests for recordingSpan method defaults * Comment why pre-allocation is not done * Correct grammar in recordingSpan allocation comment * Update sdk/trace/tracer.go Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Export resource attributes from zipkin exporter * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Refactoring * Refactoring Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* optimize(attribute): use Key's Defined method * Update kv.go
* Update versions.yaml * Update changelog * Upgrade stable-v1 to version v1.4.0 * Upgrade experimental-metrics to version v0.27.0 * Upgrade bridge to version v0.27.0 * Update CHANGELOG.md
Disable all default linters prior to enabling the ones we want to ensure that no upgrade that include new default linters introduce changes to the CI system.
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Refactor Makefile * Update dependabot targets * Sync github actions config with Makefile ci target * Update test targets * Use sed instead of parameter indexing * Remove dependabot-generate Address in open-telemetry#2613 instead.
…y#2615) * Fix race condition in reading the dropped spans number As any race condition this should be consider an undefined behavior, and a patch release should be done. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update versions.yaml * Prepare stable-v1 for version v1.4.1 * Prepare experimental-metrics for version v0.27.1 * Prepare bridge for version v0.27.1 * Update CHANGELOG * Revert "Prepare experimental-metrics for version v0.27.1" This reverts commit 838743a. * Do not release experimental-metrics with v0.27.1
…en-telemetry#2601) * feature/exporter: add Drop Counts for oltptracer's event Signed-off-by: 1046102779 <seachen@tencent.com> * feature/exporter: add Drop Counts for oltptracer's event Signed-off-by: 1046102779 <seachen@tencent.com> * feature/exporter: add Drop Counts for oltptracer's event and link Signed-off-by: 1046102779 <seachen@tencent.com> * feature/exporter: add Drop Counts for oltptracer's event and link Signed-off-by: 1046102779 <seachen@tencent.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Refactor common repo code for crosslink * Add dbotconf utility * Add dependabot-generate target to Makefile * Generate dependabot.yml * Update Makefile targets related to dependabot-generate
…2621) Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* add env support for otel_span configuration Signed-off-by: Cuichen Li <cuichli@cisco.com> * update changelog * update changelog and some logic based on comment * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * add document about retrieve value from environment variable Signed-off-by: Cuichen Li <cuichli@cisco.com> * remove trailing whitespace Signed-off-by: Cuichen Li <cuichli@cisco.com> * parse environment variable before apply the options * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update sdk/trace/provider_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…en-telemetry#2616) * remove the limit of SpanEvents when exporting * fix changelog * Update exporters/otlp/otlptrace/internal/tracetransform/span.go Co-authored-by: Sam Xie <xsambundy@gmail.com> * Update exporters/otlp/otlptrace/internal/tracetransform/span.go Co-authored-by: Sam Xie <xsambundy@gmail.com> * Update exporters/otlp/otlptrace/internal/tracetransform/span.go Co-authored-by: Sam Xie <xsambundy@gmail.com> * Update CHANGELOG.md Co-authored-by: Sam Xie <xsambundy@gmail.com> * fix unused param * fix changelog * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * fix unittest * fix code format Co-authored-by: Sam Xie <xsambundy@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…rnal/tools (open-telemetry#2624) * Bump github.com/golangci/golangci-lint in /internal/tools Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.44.0 to 1.44.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.44.0...v1.44.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
* setup benchmarks github action * run on go 1.16 * only run benchmarks on a push * pin all actions
…rnal/tools (open-telemetry#2626) * Bump github.com/golangci/golangci-lint in /internal/tools Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.44.1 to 1.44.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.44.1...v1.44.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
) * use randomly-available port in otlp exporters tests * Update exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/otlptrace/otlptracegrpc/client_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
…#2592) * todo(tracestate): drop right-most member in tracestate Signed-off-by: 1046102779 <seachen@tencent.com> * fix(tracestate): drop right-most member in tracestate Signed-off-by: 1046102779 <seachen@tencent.com> * fix(tracestate): drop right-most member in tracestate Signed-off-by: 1046102779 <seachen@tencent.com> * fix(tracestate): drop right-most member in tracestate Signed-off-by: 1046102779 <seachen@tencent.com> * fix(tracestate): drop right-most member in tracestate Signed-off-by: 1046102779 <seachen@tencent.com> * Update trace/tracestate.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Use port 4318 for otlptracehttp client default * Use port 4318 for otlpmetrichttp client default * Add changes to changelog * Fix arg pass error * Simplify defaultPath path parsing
Per the specification: open-telemetry/opentelemetry-specification#2262 Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* update debug message * update changelog Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add Marshaling implementations for exporters * Changelog * Fix changelog Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…en-telemetry#2622) * replace master with specific jaeger tag version in otel-collector * change version * update jeager-operator version in makefile
* unify otlp path parsing/default logic * add changelog * add license and unit test * remove else branch * increase unitt test coverage * add vanity import * Update exporters/otlp/internal/config.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * format the config_test.go * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config.go Co-authored-by: Sam Xie <sam@samxie.me> * change URLPath to urlPath Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Sam Xie <sam@samxie.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a demonstration the feedback and approvals should be put in the original
This fixes and updates tests and examples. Makes the SDK once again useable.