Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the remaining tests. #684

Closed
wants to merge 40 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
2e75522
This fixes the remaing tests.
MadVikingGod Feb 7, 2022
09f0446
Update changelog
MadVikingGod Feb 7, 2022
20d9758
fix pull_test
MadVikingGod Feb 7, 2022
98bb105
Replace recordingSpan attributes implementation with slice of attribu…
MrAlias Feb 7, 2022
10b58d6
Update tracestate.go (#2590)
1046102779 Feb 8, 2022
9f42a81
Export resource attributes from zipkin exporter (#2589)
tttanikawa Feb 9, 2022
010ca4f
use subtests in the trace package (#2594)
dmathieu Feb 9, 2022
b01dc21
refactor: use Key's Defined method (#2593)
1046102779 Feb 11, 2022
1bda062
Release v1.4.0/v0.27.0 (#2600)
MrAlias Feb 11, 2022
25827f0
Lock down golangci-lint config (#2602)
MrAlias Feb 14, 2022
f5c4874
Bump actions/setup-go from 2.1.5 to 2.2.0 (#2603)
dependabot[bot] Feb 14, 2022
cd21df4
Refactor development/CI tooling (#2609)
MrAlias Feb 15, 2022
2a9cedf
Fix race condition in reading the dropped spans number (#2615)
Feb 16, 2022
065ba75
Release v1.4.1/v0.27.1 (#2619)
MrAlias Feb 16, 2022
67f508b
feature/exporter: add Drop Counts for oltptracer's event and link (#2…
1046102779 Feb 16, 2022
d46c0d2
Add dependabot-generate make target (#2613)
MrAlias Feb 17, 2022
b675dda
Fix typo in using instrumentation libraries markdown (#2621)
bvwells Feb 17, 2022
98c2c9d
Add env support for span limits configuration (#2606)
cuichenli Feb 17, 2022
8297dbf
Remove the otlp trace exporter limit of SpanEvents when exporting (#…
hanyuancheung Feb 17, 2022
8ebef75
Bump github.com/golangci/golangci-lint from 1.44.0 to 1.44.1 in /inte…
dependabot[bot] Feb 17, 2022
5ba3866
Setup benchmarks github action (#2559)
dmathieu Feb 18, 2022
8ba8f68
Bump github.com/golangci/golangci-lint from 1.44.1 to 1.44.2 in /inte…
dependabot[bot] Feb 22, 2022
d51d1b3
Use randomly-available port in otlp exporters tests (#2627)
dmathieu Feb 22, 2022
94b1848
fix(tracestate): drop right-most member in tracestate (#2592)
1046102779 Feb 23, 2022
0a6e4d8
Use port 4318 for otlp*http client default (#2625)
MrAlias Feb 23, 2022
a15269a
change `gc` runtime name to `go` (#2560)
dmathieu Feb 23, 2022
52e921c
Merge remote-tracking branch 'upstream/main' into metrics-api/4-tests
MadVikingGod Feb 23, 2022
b6c7e7c
Fixes for PR comments.
MadVikingGod Feb 23, 2022
18b9fc4
refactor the noop meter and instruments into one package.
MadVikingGod Feb 23, 2022
32b6eba
Fix linting
MadVikingGod Feb 23, 2022
d8ebfab
Fix mod tidy.
MadVikingGod Feb 24, 2022
8eb3766
Update BatchSpanProcessor debug message (#2640)
MadVikingGod Feb 25, 2022
76bff3f
add hanyuancheung as an approver (#2638)
hanyuancheung Feb 25, 2022
a1fff3c
Add Marshaling implementations for exporters (#2578)
MadVikingGod Feb 25, 2022
0dd1d52
Renamed pkg.Instruments to pkg.InstrumentProvider
MadVikingGod Feb 25, 2022
775fb28
Merge remote-tracking branch 'upstream/main' into metrics-api/4-tests
MadVikingGod Feb 25, 2022
33a5a49
Replace master with specific jaeger tag version in otel-collector (#2…
hanyuancheung Mar 1, 2022
79f6bc1
remove old prom-collector depandence (#2643)
hanyuancheung Mar 1, 2022
b66c902
Unify OTLP path parsing/default Logic (#2639)
hanyuancheung Mar 2, 2022
4792a7c
Merge remote-tracking branch 'upstream/main' into metrics-api/4-tests
MadVikingGod Mar 2, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
173 changes: 53 additions & 120 deletions .github/dependabot.yml

Large diffs are not rendered by default.

32 changes: 32 additions & 0 deletions .github/workflows/benchmark.yml
@@ -0,0 +1,32 @@
name: Benchmark
on:
push:
branches:
- main
env:
DEFAULT_GO_VERSION: 1.16
jobs:
benchmark:
name: Benchmarks
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.4.0
- uses: actions/setup-go@v2.2.0
with:
go-version: ${{ env.DEFAULT_GO_VERSION }}
- name: Run benchmarks
run: make test-bench | tee output.txt
- name: Download previous benchmark data
uses: actions/cache@v2.1.7
with:
path: ./benchmarks
key: ${{ runner.os }}-benchmark
- name: Store benchmarks result
uses: benchmark-action/github-action-benchmark@v1.13.0
with:
name: Benchmarks
tool: 'go'
output-file-path: output.txt
external-data-json-path: ./benchmarks/data.json
auto-push: false
fail-on-alert: true
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install Go
uses: actions/setup-go@v2.1.5
uses: actions/setup-go@v2.2.0
with:
go-version: ${{ env.DEFAULT_GO_VERSION }}
- name: Checkout Repo
Expand All @@ -40,15 +40,15 @@ jobs:
- name: Run linters
run: make dependabot-check license-check lint vanity-import-check
- name: Build
run: make examples build
run: make build
- name: Check clean repository
run: make check-clean-work-tree

test-race:
runs-on: ubuntu-latest
steps:
- name: Install Go
uses: actions/setup-go@v2.1.5
uses: actions/setup-go@v2.2.0
with:
go-version: ${{ env.DEFAULT_GO_VERSION }}
- name: Checkout Repo
Expand All @@ -71,7 +71,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install Go
uses: actions/setup-go@v2.1.5
uses: actions/setup-go@v2.2.0
with:
go-version: ${{ env.DEFAULT_GO_VERSION }}
- name: Checkout Repo
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Install Go
uses: actions/setup-go@v2.1.5
uses: actions/setup-go@v2.2.0
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot.yml
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.head_ref }}
- uses: actions/setup-go@v2.1.5
- uses: actions/setup-go@v2.2.0
with:
go-version: '^1.16.0'
- uses: evantorrie/mott-the-tidier@v1-beta
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Expand Up @@ -16,6 +16,5 @@ gen/
/example/opencensus/opencensus
/example/passthrough/passthrough
/example/prometheus/prometheus
/example/prom-collector/prom-collector
/example/zipkin/zipkin
/example/otel-collector/otel-collector
19 changes: 17 additions & 2 deletions .golangci.yml
Expand Up @@ -4,11 +4,26 @@ run:
tests: true #Default

linters:
# Disable everything by default so upgrades to not include new "default
# enabled" linters.
disable-all: true
# Specifically enable linters we want to use.
enable:
- misspell
- deadcode
- errcheck
- gofmt
- goimports
- gosimple
- govet
- ineffassign
- misspell
- revive
- gofmt
- staticcheck
- structcheck
- typecheck
- unused
- varcheck


issues:
exclude-rules:
Expand Down
70 changes: 60 additions & 10 deletions CHANGELOG.md
Expand Up @@ -8,29 +8,77 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### ⚠️ Notice ⚠️

This update is a breaking change of the unstable Metrics API. Code instrumented with the `go.opentelemetry.io/otel/metric` <= v0.27.0 will need to be modified.

### Added

- Added support to configure the span limits with environment variables.
The following environment variables are used. (#2606)
- `OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT`
- `OTEL_SPAN_EVENT_COUNT_LIMIT`
- `OTEL_SPAN_LINK_COUNT_LIMIT`

If the provided environment variables are invalid (negative), the default values would be used.
- Rename the `gc` runtime name to `go` (#2560)
- Log the Exporters configuration in the TracerProviders message. (#2578)

### Changed

- For tracestate's members, prepend the new element and remove the oldest one, which is over capacity (#2592)
- Add event and link drop counts to the exported data from the `oltptrace` exporter. (#2601)
- The metrics API has been significantly changed. (#2587)
- Unify path cleaning functionally in the `otlpmetric` and `otlptrace` config. (#2639)
- Change the debug message from the `sdk/trace.BatchSpanProcessor` to reflect the count is cumulative. (#2640)

### Fixed

- Remove the OTLP trace exporter limit of SpanEvents when exporting. (#2616)
- Use port `4318` instead of `4317` for default for the `otlpmetrichttp` and `otlptracehttp` client. (#2614, #2625)

## [1.4.1] - 2022-02-16

### Fixed

- Fix race condition in reading the dropped spans number for the `BatchSpanProcessor`. (#2615)

## [1.4.0] - 2022-02-11

### Added

- Support `OTEL_EXPORTER_ZIPKIN_ENDPOINT` env to specify zipkin collector endpoint (#2490)
- Log the configuration of TracerProviders, and Tracers for debugging. To enable use a logger with Verbosity (V level) >=1
- Added environment variables for: `OTEL_BSP_SCHEDULE_DELAY`, `OTEL_BSP_EXPORT_TIMEOUT`, `OTEL_BSP_MAX_QUEUE_SIZE` and `OTEL_BSP_MAX_EXPORT_BATCH_SIZE` (#2515)
- Use `OTEL_EXPORTER_ZIPKIN_ENDPOINT` environment variable to specify zipkin collector endpoint. (#2490)
- Log the configuration of `TracerProvider`s, and `Tracer`s for debugging.
To enable use a logger with Verbosity (V level) `>=1`. (#2500)
- Added support to configure the batch span-processor with environment variables.
The following environment variables are used. (#2515)
- `OTEL_BSP_SCHEDULE_DELAY`
- `OTEL_BSP_EXPORT_TIMEOUT`
- `OTEL_BSP_MAX_QUEUE_SIZE`.
- `OTEL_BSP_MAX_EXPORT_BATCH_SIZE`

### Changed

- Jaeger exporter takes into additional 70 bytes overhead into consideration when sending UDP packets (#2489, #2512)
- Zipkin exporter exports `Resource` attributes in the `Tags` field. (#2589)

### Deprecated

- Deprecate module `"go.opentelemetry.io/otel/sdk/export/metric"`, new functionality available in "go.opentelemetry.io/otel/sdk/metric" module:
- Import path changed `import "go.opentelemetry.io/otel/sdk/export/metric"` to `import go.opentelemetry.io/otel/sdk/metric/export` (#2382).
- Deprecate `AtomicFieldOffsets`, unnecessary public func (#2445)
- Deprecate module the `go.opentelemetry.io/otel/sdk/export/metric`.
Use the `go.opentelemetry.io/otel/sdk/metric` module instead. (#2382)
- Deprecate `"go.opentelemetry.io/otel/sdk/metric".AtomicFieldOffsets`. (#2445)

### Fixed

- Fixes the instrument kind for noop async instruments. (#2461)
- Fixed the instrument kind for noop async instruments to correctly report an implementation. (#2461)
- Fix UDP packets overflowing with Jaeger payloads. (#2489, #2512)
- Change the `otlpmetric.Client` interface's `UploadMetrics` method to accept a single `ResourceMetrics` instead of a slice of them. (#2491)
- Specify explicit buckets in Prometheus example. (#2493)
- Specify explicit buckets in Prometheus example, fixing issue where example only has `+inf` bucket. (#2419, #2493)
- W3C baggage will now decode urlescaped values. (#2529)
- Baggage members are now only validated once, when calling `NewMember` and not also when adding it to the baggage itself. (#2522)
- The order attributes are dropped from spans in the `go.opentelemetry.io/otel/sdk/trace` package when capacity is reached is fixed to be in compliance with the OpenTelemetry specification.
Instead of dropping the least-recently-used attribute, the last added attribute is dropped.
This drop order still only applies to attributes with unique keys not already contained in the span.
If an attribute is added with a key already contained in the span, that attribute is updated to the new value being added. (#2576)

### Removed

Expand Down Expand Up @@ -1670,7 +1718,9 @@ It contains api and sdk for trace and meter.
- CircleCI build CI manifest files.
- CODEOWNERS file to track owners of this project.

[Unreleased]: https://github.com/open-telemetry/opentelemetry-go/compare/v1.3.0...HEAD
[Unreleased]: https://github.com/open-telemetry/opentelemetry-go/compare/v1.4.1...HEAD
[1.4.1]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.4.1
[1.4.0]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.4.0
[1.3.0]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.3.0
[1.2.0]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.2.0
[1.1.0]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.1.0
Expand Down
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Expand Up @@ -12,6 +12,6 @@
# https://help.github.com/en/articles/about-code-owners
#

* @jmacd @MrAlias @Aneurysm9 @evantorrie @XSAM @dashpole @paivagustavo @MadVikingGod @pellared
* @jmacd @MrAlias @Aneurysm9 @evantorrie @XSAM @dashpole @paivagustavo @MadVikingGod @pellared @hanyuancheung

CODEOWNERS @MrAlias @Aneurysm9 @MadVikingGod
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Expand Up @@ -508,6 +508,7 @@ Approvers:
- [David Ashpole](https://github.com/dashpole), Google
- [Gustavo Silva Paiva](https://github.com/paivagustavo), LightStep
- [Robert Pająk](https://github.com/pellared), Splunk
- [Chester Cheung](https://github.com/hanyuancheung), Tencent

Maintainers:

Expand Down