Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Masterminds#82] Added FROM clause to update builder #256

Merged
merged 1 commit into from Mar 17, 2023
Merged

[Masterminds#82] Added FROM clause to update builder #256

merged 1 commit into from Mar 17, 2023

Conversation

mlaflamm
Copy link
Contributor

No description provided.

@mlaflamm mlaflamm mentioned this pull request Jul 28, 2020
Closed
@Kegley
Copy link

Kegley commented Dec 1, 2020

Any updates on this PR?

@Sibley199
Copy link

Any update on this PR? Would be super useful to get this merged in if accepted

@mlaflamm
Copy link
Contributor Author

To be honest, we gave up on on squirrel shortly after submitting this PR. We are now using go-jet, a typesafe query builder with code generation. We have use it for about a year in multiple projects and we love it.

I wrote a gist explaining how we customise some of the generated data types.

@ysomad
Copy link

ysomad commented Mar 23, 2022

Any update on this?

lieut-data added a commit to lieut-data/squirrel that referenced this pull request Apr 1, 2022
@lieut-data
[Masterminds#82] Added FROM clause to update builder
d4a2ef0 
See Masterminds#256 from https://github.com/mlaflamm/squirrel.
lieut-data added a commit to mattermost/mattermost that referenced this pull request Apr 1, 2022
@lieut-data
adopt forked squirrel supporting from UPDATE FROM
79cce73 
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes:
* Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres)
* Extension of above to support multiple FROM in UPDATE (Postgres)
* Support for multiple tables in UPDATE (MySQL)

This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
@lieut-data lieut-data mentioned this pull request Apr 1, 2022
Merged
lieut-data added a commit to mattermost/mattermost that referenced this pull request Apr 4, 2022
@lieut-data
adopt forked squirrel supporting from UPDATE FROM (#19896)
7b5ac34 
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes:
* Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres)
* Extension of above to support multiple FROM in UPDATE (Postgres)
* Support for multiple tables in UPDATE (MySQL)

This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
mylonsuren pushed a commit to mylonsuren/mattermost-server that referenced this pull request Apr 5, 2022
@lieut-data @mylonsuren
adopt forked squirrel supporting from UPDATE FROM (mattermost#19896)
1d9aa00 
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes:
* Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres)
* Extension of above to support multiple FROM in UPDATE (Postgres)
* Support for multiple tables in UPDATE (MySQL)

This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
Willyfrog pushed a commit to Willyfrog/mattermost-server that referenced this pull request Apr 8, 2022
@lieut-data
adopt forked squirrel supporting from UPDATE FROM (mattermost#19896)
3e3085b 
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes:
* Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres)
* Extension of above to support multiple FROM in UPDATE (Postgres)
* Support for multiple tables in UPDATE (MySQL)

This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
FreedomBen pushed a commit to FreedomBen/mattermost-server that referenced this pull request Jun 14, 2022
@lieut-data @FreedomBen
adopt forked squirrel supporting from UPDATE FROM (mattermost#19896)
1a4a2e2 
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes:
* Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres)
* Extension of above to support multiple FROM in UPDATE (Postgres)
* Support for multiple tables in UPDATE (MySQL)

This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
@yazver
Copy link

yazver commented Mar 17, 2023

Why hasn't it been merged until now?

@lann lann merged commit d8eb51b into Masterminds:master Mar 17, 2023
@ysomad
Copy link

ysomad commented Mar 17, 2023

Oh I cant believe, finally its merged. Thank you!

@Kegley
Copy link

Kegley commented Mar 17, 2023

Proof change really can happen 🥹

ovadbar added a commit to ovadbar/squirrel that referenced this pull request Apr 3, 2023
@ovadbar
Merge pull request #1 from Masterminds/master
779a1df 
[Masterminds#82] Added FROM clause to update builder (Masterminds#256)
joshring added a commit to joshring/squirrel that referenced this pull request Feb 22, 2024
@joshring
Merge pull request #2 from Masterminds/master
476d001 
[Masterminds#82] Added FROM clause to update builder (Masterminds#256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mlaflamm @Kegley @Sibley199 @ysomad @yazver @lann