narrowlink: init at 0.1.4 #248723
narrowlink: init at 0.1.4 #248723
Conversation
|
|
||
| rustPlatform.buildRustPackage rec { | ||
| pname = "narrowlink"; | ||
| version = "0.1.2"; |
There was a problem hiding this comment.
0.1.3 is out, but it's fine to leave that for follow-up IMO.
| }; | ||
|
|
||
| postPatch = '' | ||
| ln -s ${./Cargo.lock} Cargo.lock |
There was a problem hiding this comment.
Would be nice if upstream kept this in version control. Maybe ask them?
There was a problem hiding this comment.
There was a problem hiding this comment.
@SajjadPourali can you please cut a release after the lock-file addition commit? That would make automating updating this package a bit simpler here.
Also since you commented, do you have any idea why the build is failing on x86_64-darwin - build logs here - https://logs.ofborg.org/?key=nixos/nixpkgs.248723&attempt_id=d7ae30ff-d5b7-4cb0-9d55-884033c82973
There was a problem hiding this comment.
I think the failure is due to using Apple SDK 10 instead of 11. Please take a look at this issue for more info: GuillaumeGomez/sysinfo#915
For the tag/release, does https://github.com/narrowlink/narrowlink/releases/tag/Nightly works for you? It might take a bit time for the actual release.
There was a problem hiding this comment.
Thanks! The build failure is solved!
Using the Nightly tag will imply making the version unstable-DDDD-MM-YY. Do you think cutting a minor or patch release is possible?
There are workarounds but not clean.
There was a problem hiding this comment.
The new release will be done after narrowlink/narrowlink#28. I plan to finish it by this weekend.
There was a problem hiding this comment.
Thanks! The build failure is solved!
Using the
Nightlytag will imply making the versionunstable-DDDD-MM-YY. Do you think cutting a minor or patch release is possible?There are workarounds but not clean.
@dit7ya Done https://github.com/narrowlink/narrowlink/tree/0.1.4
There was a problem hiding this comment.
Done, the Cargo.lock is still outdated but I figured using a patch (much smaller than checking in the entire lockfile) is faster than waiting for the next release.
|
Once this gets merged I'll make a nixos module for it. |
| ]; | ||
|
|
||
| meta = { | ||
| description = "Narrowlink securely connects devices and services together, even when both nodes are behind separate NAT"; |
There was a problem hiding this comment.
Damn, I forgot to remove the package name from the description. I guess its for the next update then 🤷 .
Description of changes
Closes #248617.
Disclaimer: I haven't tested the resulting binaries thoroughly yet.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)