Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.radios: 0.3.0 -> 0.3.1 #295505

Merged
merged 7 commits into from Mar 13, 2024
Merged

python311Packages.radios: 0.3.0 -> 0.3.1 #295505

merged 7 commits into from Mar 13, 2024

Conversation

dotlambda
Copy link
Member

Description of changes

Diff: frenck/python-radios@v0.3.0...v0.3.1

Changelog: https://github.com/frenck/python-radios/releases/tag/v0.3.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@dotlambda dotlambda changed the base branch from master to staging March 13, 2024 03:21
@dotlambda dotlambda requested a review from mweinelt March 13, 2024 03:41
@dotlambda dotlambda changed the base branch from staging to staging-next March 13, 2024 03:46
@dotlambda
Copy link
Member Author

@mweinelt Would you prefer I move the pycountry commit to staging?

DamienCassou
DamienCassou approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the rationale for some changes. Could the commit messages detail them a bit?

Also, is there any relationship between these commits?

pkgs/development/python-modules/xhtml2pdf/default.nix
pyproject = true;

disabled = pythonOlder "3.8";

src = fetchFromGitHub {
owner = pname;
repo = pname;
owner = "xhtml2pdf";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because semantically they're not the same thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#277994

pkgs/development/python-modules/woob/default.nix
@@ -55,17 +51,18 @@ buildPythonPackage rec {
pyyaml
requests
rich
termcolor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing these dependencies?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we always miss things in the python-updates bulk update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched the upstream code for the dependency and couldn't find it.

pkgs/development/python-modules/woob/default.nix

disabled = pythonOlder "3.7";

src = fetchFromGitLab {
owner = "woob";
repo = pname;
repo = "woob";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#277994

@mweinelt
Copy link
Member

@mweinelt Would you prefer I move the pycountry commit to staging?

Not really, we are still early enough in staging-next.

@mweinelt mweinelt merged commit 4ee0840 into NixOS:staging-next Mar 13, 2024
25 checks passed
@dotlambda
Copy link
Member Author

Also, is there any relationship between these commits?

They all came up as broken after trying to update pycountry.

@dotlambda dotlambda deleted the radios-0.3.1 branch March 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamienCassou DamienCassou DamienCassou approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@zraexy zraexy Awaiting requested review from zraexy

@DeeUnderscore DeeUnderscore Awaiting requested review from DeeUnderscore

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @mweinelt @DamienCassou @delroth