Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.radios: 0.3.0 -> 0.3.1 #295505

Merged
merged 7 commits into from Mar 13, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 12 additions & 14 deletions pkgs/development/python-modules/woob/default.nix
Expand Up @@ -3,21 +3,19 @@
, buildPythonPackage
, fetchFromGitLab
, fetchpatch
, gnupg
, html2text
, libyaml
, lxml
, nose
, packaging
, pillow
, prettytable
, pycountry
, pytestCheckHook
, python-dateutil
, pythonOlder
, pyyaml
, requests
, rich
, termcolor
, setuptools
, testers
, unidecode
, woob
Expand All @@ -26,27 +24,25 @@
buildPythonPackage rec {
pname = "woob";
version = "3.6";
format = "pyproject";
pyproject = true;

disabled = pythonOlder "3.7";

src = fetchFromGitLab {
owner = "woob";
repo = pname;
repo = "woob";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev = version;
hash = "sha256-M9AjV954H1w64YGCVxDEGGSnoEbmocG3zwltob6IW04=";
};

nativeBuildInputs = [
packaging
setuptools
];

propagatedBuildInputs = [
babel
python-dateutil
gnupg
html2text
libyaml
lxml
packaging
pillow
Expand All @@ -55,17 +51,18 @@ buildPythonPackage rec {
pyyaml
requests
rich
termcolor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing these dependencies?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we always miss things in the python-updates bulk update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched the upstream code for the dependency and couldn't find it.

unidecode
];

nativeCheckInputs = [
nose
pytestCheckHook
];

checkPhase = ''
nosetests
'';
disabledTests = [
# require networking
"test_ciphers"
"test_verify"
];

pythonImportsCheck = [
"woob"
Expand All @@ -77,6 +74,7 @@ buildPythonPackage rec {
};

meta = with lib; {
changelog = "https://gitlab.com/woob/woob/-/blob/${src.rev}/ChangeLog";
description = "Collection of applications and APIs to interact with websites";
homepage = "https://woob.tech";
license = licenses.lgpl3Plus;
Expand Down