-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Canary Release #490
Conversation
9fafbdb
to
5ef23e3
Compare
This PR is ready for review, it works for me well. apiVersion: core.openfunction.io/v1beta2
kind: Function
metadata:
name: test-server
spec:
canarySteps:
- weight: 20
pause:
duration: 60
- weight: 80
pause:
duration: 120
image: brycehuang/web-service-image:v1
serving:
template:
containers:
- imagePullPolicy: IfNotPresent
name: function
version: latest
workloadRuntime: OCIContaine After modifying the image brycehuang/web-service-image:v1 to brycehuang/web:v2, start the canary release. You can observe the changes in httproute. After about 3 minutes, the canary release is completed. |
The e2e test has know issues which is still failing, it's ok not to fix it now. |
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
f339c1a
to
59f11e5
Compare
@Bryce-huang Is this ready for review? |
Yes,I'm also doing tests. |
@wrongerror @wanjunlei @tpiperatgod @lizzzcai would you help to review this? |
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com> # Conflicts: # controllers/core/function_controller.go # go.mod # go.sum # pkg/constants/constants.go
4809742
to
a0a3c71
Compare
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com> Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
# Conflicts: # controllers/core/function_controller.go
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com> Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
I would suggest the following changes: apiVersion: core.openfunction.io/v1beta2
kind: Function
metadata:
name: test-server
spec:
rolloutStrategy:
canary:
steps:
- weight: 20
pause:
duration: 60
- weight: 80
pause:
duration: 120
image: brycehuang/web-service-image:v1
serving:
template:
containers:
- imagePullPolicy: IfNotPresent
name: function
version: latest
workloadRuntime: OCIContainer
status:
# status.serving and status.revision should always be the stable serving and revision
# status.canary.serving and status.canary.revision should be the canary ones
serving:
revision:
rollout:
canary:
status: # CanaryStatus
serving:
revision: |
LGTM |
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
# Conflicts: # apis/core/v1beta2/function_webhook.go # controllers/core/function_controller.go # pkg/core/serving/knative/servingrun.go
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
9dade78
to
66ed784
Compare
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
dc16b97
to
c01dd1f
Compare
OpenFunction#504 Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
Signed-off-by: Bryce-Huang <44901318+Bryce-huang@users.noreply.github.com>
#487