Using prettify instead of pretty-quick-wrapper #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnStutzenstein
force-pushed
the
prettify
branch
from
d02d42e
to
e8319c4
Compare
jsaalfeld
approved these changes
Dec 17, 2018
FinnStutzenstein
force-pushed
the
prettify
branch
from
aa65f4f
to
1c895fb
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty-quick is just a wrapper for prettier. It does not support a CI, because even with changed files, the process exits with 0 (prettier/pretty-quick#53 Introduces this feature, but the PR was just created). Also, pretty-quick did not check already committed files, which is senseless in a CI. This PR fixes all files and adds prettify to the project, so all source files are pretty once this PR is merged.