-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute overhaul #3245
base: master
Are you sure you want to change the base?
Attribute overhaul #3245
Conversation
d9cfefe
to
11f802f
Compare
1805e6f
to
c51f9fa
Compare
c51f9fa
to
997d1de
Compare
Probably a bit late that I thought of this, but wouldn't the attribute better be defined as a new property in the digitizer identifier? |
This probably isn't the best case considering improving the detection scheme further would add extra attributes, putting extra filters in place. See #3011 for what else could be added in the future. |
#3276 requires Interface 0, there are 3 interfaces all with the same input and output lengths. |
Will rebase this PR and backport it when we close in on the next release and merge some configurations, its not fair on others to rebase 70+ configuration pull requests because i changed the configuration format. |
Turns out we have had this for a while, just in a different file out of sight.
Supersedes #3243.
Fixes #2438.
TODO:
FeatureInitDelayMs
attribute.DigitizerIdentifiers
.I have something I'm not the most sure on right now, should a method be implemented somewhere to get the combined attributes? Right now it has absolutely no demand and its not complex logic to begin with, and use for combined attributes only are required in one spot, so its not like any code duplication will happen if we don't implement one.
At this time I'm not going to add support for FeatureInitDelayMs or libinputoverride in specific device identifiers, this is not needed and just increases complexity, but implementing the above would amend that. But considering the usage of delay (only intuos3 and on ALL tablets regardless of identifier) there is absolutely no need to implement support into the identifiers too.
Reminder to submit a pull request for web once this is merged.
The most recent commit may break WinUSB?