Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute overhaul #3245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented Mar 12, 2024

Supersedes #3243.
Fixes #2438.

TODO:

  • Add attribute to force specific interface on Linux & unify attributes to "Interface".
  • Restore FeatureInitDelayMs attribute.
  • Add support for specific identifiers via DigitizerIdentifiers.
  • Document changes in the codebase.
  • Modify all configurations to include new attributes.

I have something I'm not the most sure on right now, should a method be implemented somewhere to get the combined attributes? Right now it has absolutely no demand and its not complex logic to begin with, and use for combined attributes only are required in one spot, so its not like any code duplication will happen if we don't implement one.

At this time I'm not going to add support for FeatureInitDelayMs or libinputoverride in specific device identifiers, this is not needed and just increases complexity, but implementing the above would amend that. But considering the usage of delay (only intuos3 and on ALL tablets regardless of identifier) there is absolutely no need to implement support into the identifiers too.

Reminder to submit a pull request for web once this is merged.

The most recent commit may break WinUSB?

@jamesbt365 jamesbt365 added desktop OpenTabletDriver.Desktop library, UX and Daemon use this as the core implementation. enhancement New feature or request labels Mar 12, 2024
@jamesbt365 jamesbt365 force-pushed the attribute-overhaul branch 4 times, most recently from d9cfefe to 11f802f Compare March 14, 2024 17:18
@jamesbt365 jamesbt365 marked this pull request as ready for review March 14, 2024 17:47
@gonX
Copy link
Member

gonX commented Mar 16, 2024

Probably a bit late that I thought of this, but wouldn't the attribute better be defined as a new property in the digitizer identifier?

@jamesbt365
Copy link
Member Author

Probably a bit late that I thought of this, but wouldn't the attribute better be defined as a new property in the digitizer identifier?

This probably isn't the best case considering improving the detection scheme further would add extra attributes, putting extra filters in place. See #3011 for what else could be added in the future.

@jamesbt365 jamesbt365 added the configuration Adds or modifies a tablet configuration label Mar 22, 2024
@jamesbt365
Copy link
Member Author

#3276 requires Interface 0, there are 3 interfaces all with the same input and output lengths.

@jamesbt365
Copy link
Member Author

Will rebase this PR and backport it when we close in on the next release and merge some configurations, its not fair on others to rebase 70+ configuration pull requests because i changed the configuration format.

Turns out we have had this for a while, just in a different file out of
sight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Adds or modifies a tablet configuration desktop OpenTabletDriver.Desktop library, UX and Daemon use this as the core implementation. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for feature initialization delay lost after DI
2 participants