Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XP-Pen Artist 16 #3276

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Mat931
Copy link

@Mat931 Mat931 commented Apr 10, 2024

No description provided.

@Mat931 Mat931 marked this pull request as ready for review April 10, 2024 20:56
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also strongly prefer a diagnostic be provided as per our CONTRIBUTING.md when adding support for tablets. Please provide the file generated from help > export diagnostics

"FeatureInitReport": null,
"OutputInitReport": null,
"DeviceStrings": {},
"InitializationStrings": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you need every string here for full functionality?

Judging from other tablets only 100 should be required, 123 may be required for aux functionality, could you provide a string dump from the inbuilt device string reader?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I tried removing every single one of them. 123 is to switch to the correct aux button format but that also seems to mess up the dpi. It sometimes works if the 100 is removed but not reliably. These were captured using usbmon from the Windows driver running inside a virtual machine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I use the string reader?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OEM driver will throw strings that the tablet does not need and are simply denied by the tablet.

put 21827 in the top, 77 in the middle and ignore the bottom box, dump all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try only 100 and 123, replug your tablet to reset the initialization process.

"Digitizer": {
"Width": 340.99,
"Height": 191.81,
"MaxX": 34416,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure these are right? If these are the highest values you can get you should adjust the width and weight to reflect these properly.

max value/lpmm = physical size

the lpmm for this tablet is 100 and the max value is what you can measure in the tablet > tablet debugger when moving your pen as far as you can get it to read.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MaxX and MaxY are from the tablet debugger. The width and height are copied from a different 16" tablet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should calculate the values using the formula provided and use those instead.

"MaxY": 19359
},
"Pen": {
"MaxPressure": 2047,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XP-Pen likes to hide old tablets specification pages so I can't compare this alongside a spec sheet at this time, is this the value you got when you measured it in tablet > tablet debugger?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxPressure is also the highest value seen in the tablet debugger

"ProductID": 77,
"InputReportLength": 8,
"OutputReportLength": 0,
"ReportParser": "OpenTabletDriver.Configurations.Parsers.XP_Pen.XP_PenOffsetAuxReportParser",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the right parser? Its currently only used on the UGEE M708 (UGEE and XP-Pen are close companies so its fine if this is the right parser)

The only difference is where it reads auxiliary data from, so if it reads fine this is the right parser.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. With other parsers the aux buttons don't work

@Mat931
Copy link
Author

Mat931 commented Apr 10, 2024

@jamesbt365
Copy link
Member

jamesbt365 commented Apr 10, 2024

Functionality of this tablet will be spotty until #3245 is merged. It currently has a 1/3 chance of working, with invoking detection and hoping you hit a 1/3 being the only way to make it work.

@jamesbt365 jamesbt365 mentioned this pull request Apr 10, 2024
5 tasks
@Mat931
Copy link
Author

Mat931 commented Apr 10, 2024

@jamesbt365 jamesbt365 added configuration Adds or modifies a tablet configuration needs-backport PR needs to be backported to stable branch labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Adds or modifies a tablet configuration needs-backport PR needs to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants