Add ERC20 Permit (EIP-2612) #2237
Conversation
|
Previous discussion about EIP712 in #1810. |
|
The Uniswap tests might be a good starting place to write the tests for this. We can also look into using |
| abi.encode( | ||
| keccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)"), | ||
| keccak256(bytes(name())), | ||
| keccak256(bytes("1")), // Version |
There was a problem hiding this comment.
It seems we should use pure internal method version() or permitVersion() for this.
There was a problem hiding this comment.
Are you suggesting an internal setter for users to set their own version field? I'm actually not sure what all the use cases for version are, if you have insights on this that'd be extremely helpful.
That said we do need to provide a way for either the version or domain separator to be queried, as noted here.
There was a problem hiding this comment.
I believe version makes sense when behaviour changes without address change (upgradablity?). So I mean version method could be overrided by user, or maybe should be even abstract.
There was a problem hiding this comment.
I see. It'd be great to have some examples to show in the docs.
Regarding implementation, we could have a setter and a getter, where the setter also calls _updateDomainSeparator and not increase gas costs of permit that way.
There was a problem hiding this comment.
@k06a In this case though the semantics of the signature are defined by the EIP, so I don't see a reason for version to change.
This comment has been minimized.
This comment has been minimized.
frangio
added
the
on hold
|
While we still have to work on the tests for this feature, it's kind of on hold because the ERC is in Draft status. |
|
Stumbled upon this while working on my eth-permit library Might be useful for your unit tests |
|
@dmihal Looks like it will be useful, thank you! |
|
With a few modifications, I successfully used the |
|
@gorgos the new version of eth-permit should work correctly. And feel free to add PRs to https://github.com/dmihal/eth-permit 🙂 |
|
Is anyone familiar with the finalization status of this EIP? If there are any plans to move it to Final? |
|
@spalladino @mverzilli The code is ready for review. I still need to review the documentation a little bit. If you have any opinions on that front let me know. |
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
Fixes #2206
This adds support for the ERC20 Permit extension, tentatively called ERC2612 and based on the discussion in ethereum/EIPs#2612. The EIP is still in draft status,
we'll need to monitor it for any changes, and will likely not want to publish this code until it is more mature / finalizedso it will go in the drafts directory.This implementation accounts for
ChainIDchanging (i.e. a hard fork) while at the same time being as gas efficient as possible.The code and documentation is ready, but the tests are not,
To do
ERC20PermitvsERC2612PermitorERC2612