Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC20 Permit (EIP-2612) #2237

Merged
merged 38 commits into from
Dec 11, 2020
Merged

Add ERC20 Permit (EIP-2612) #2237

merged 38 commits into from
Dec 11, 2020

Commits on May 15, 2020

  1. Initial storage-based implementation

    @nventuro
    nventuro committed May 15, 2020
    Configuration menu
    Copy the full SHA
    19a413a View commit details
    Browse the repository at this point in the history

  2. Improve gas efficiency and docs

    @nventuro
    nventuro committed May 15, 2020
    Configuration menu
    Copy the full SHA
    48c41df View commit details
    Browse the repository at this point in the history

  3. Initial sketch for tests

    @nventuro
    nventuro committed May 15, 2020
    Configuration menu
    Copy the full SHA
    d1e0f4b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Fix encoding before hash

    @nventuro
    nventuro committed May 26, 2020
    Configuration menu
    Copy the full SHA
    cf718ee View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Implement nonce using Counter

    @nventuro
    nventuro committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    53516bc View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Merge branch 'master' into erc20-permit

    @frangio
    frangio committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    be37397 View commit details
    Browse the repository at this point in the history

  2. adjust pragma and add license

    @frangio
    frangio committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    743fe9a View commit details
    Browse the repository at this point in the history

  3. adapt test to buidler

    @frangio
    frangio committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    0c02fdc View commit details
    Browse the repository at this point in the history

  4. disable eslint in wip file

    @frangio
    frangio committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    255e11a View commit details
    Browse the repository at this point in the history

  5. add solhint exceptions

    @frangio
    frangio committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    d5037d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. use a cheaper strategy for domain separator caching

    @frangio
    frangio committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    b11d7ab View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. add DOMAIN_SEPARATOR function

    @frangio
    frangio committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    58c7098 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into erc20-permit

    @frangio
    frangio committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    1bd9922 View commit details
    Browse the repository at this point in the history

  3. add eip712 from OpenZeppelin#2418

    @frangio
    frangio committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    cb00f8a View commit details
    Browse the repository at this point in the history

  4. move to drafts directory

    @frangio
    frangio committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    c5d01e9 View commit details
    Browse the repository at this point in the history

  5. use EIP712 contract

    @frangio
    frangio committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    aacea0c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. fix test

    @frangio
    frangio committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    b57f655 View commit details
    Browse the repository at this point in the history

  2. emit contract in api/drafts page

    @frangio
    frangio committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    0560ea8 View commit details
    Browse the repository at this point in the history

  3. fix api/drafts page title

    @frangio
    frangio committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    4552f52 View commit details
    Browse the repository at this point in the history

  4. add constructor documentation

    @frangio
    frangio committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9a916f7 View commit details
    Browse the repository at this point in the history

  5. lint

    @frangio
    frangio committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    91e98a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. extract eip712 helpers

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    e331820 View commit details
    Browse the repository at this point in the history

  2. test DOMAIN_SEPARATOR function

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    ade3af2 View commit details
    Browse the repository at this point in the history

  3. test permit postconditions

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    9a661c9 View commit details
    Browse the repository at this point in the history

  4. use different account for nonce test

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    f4b7f93 View commit details
    Browse the repository at this point in the history

  5. add test for rejected transaction

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    8f7f47c View commit details
    Browse the repository at this point in the history

  6. test expired permit

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    b7b5abd View commit details
    Browse the repository at this point in the history

  7. remove note about domain separator and chain id

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    24e4582 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master' into erc20-permit

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    737fa3b View commit details
    Browse the repository at this point in the history

  9. ensure deadline is before next block timestamp

    @frangio
    frangio committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    f410734 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Update contracts/token/ERC20/README.adoc 

    Co-authored-by: Santiago Palladino <spalladino@gmail.com>
    @frangio @spalladino
    frangio and spalladino committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    9d60a71 View commit details
    Browse the repository at this point in the history

  2. add test that reused signature is rejected

    @frangio
    frangio committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    3beaf01 View commit details
    Browse the repository at this point in the history

  3. use valid signature when testing expired deadline

    @frangio
    frangio committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    837586d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into erc20-permit

    @frangio
    frangio committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    add4067 View commit details
    Browse the repository at this point in the history

  5. rename IERC2612Permit to IERC20Permit

    @frangio
    frangio committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    f26f0e3 View commit details
    Browse the repository at this point in the history

  6. review documentation

    @frangio
    frangio committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    acd82cd View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Merge branch 'master' into erc20-permit

    @frangio
    frangio committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    4444d3b View commit details
    Browse the repository at this point in the history

  2. add changelog entry

    @frangio
    frangio committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    71c9e3d View commit details
    Browse the repository at this point in the history