Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As it was, the plugin when used by external standards, would block them from being tested on PHP 8.
As all the dependencies in the
require
section allow for PHP 8, there is no reason not to allow it.The only dependencies currently in use which do not allow for PHP 8 yet are in the
require-dev
section. See the below output.This includes updating the Travis script to:
dev
) install when not onnightly
.nightly
as otherwise thedev
requirements would still block installation.require-dev
section, we need to require it explicitly fornightly
to make sure the integration test can run.As the Travis build on PHP
nightly
passes, I'm semi-confident that all should be good, though confidence will grow once we add more unit/integration tests.