Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Minified CSS using gulp-clean-css API #2553

Closed
wants to merge 3 commits into from

Conversation

ashwinjayan
Copy link
Contributor

Minified css automatically generated using gulp-clean-css added to gulpfile.js folder

@RunDevelopment
Copy link
Member

Thank you for making this PR @ashwinjayan!
(You forgot to add gulp-clean-css as a dev dependency. Please commit the changes to package.json and package-lock.json.)

@ashwinjayan @mAAdhaTTah @LeaVerou @Golmote
Is this something we want/need for Prism? I see that it makes sense to offer minified themes and plugin CSS but I never saw this as a priority because the file size of minified themes is only about 25% to 30% less than the unminified versions.

Note: If we added the minified files, we should also add support for this to the download page (shouldn't be too hard). However, changes to the download page shouldn't be part of this PR, IMO.

Thoughts?


Related issues: #2546, #956

to dev dependencies
@ashwinjayan
Copy link
Contributor Author

Hi @RunDevelopment, I missed to save the dependency. Have added it to dev-dependency and committed.

linkify,
changes
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but this should keep the newline.

@mAAdhaTTah
Copy link
Member

@RunDevelopment How hard would it be to add to the download page? @ashwinjayan Is this something you'd be willing to tackle?

I do think it's a little curious we provide the JS minified and not the CSS so I'm open to adding this, but we should probs include the download page change as part of this.

@RunDevelopment
Copy link
Member

How hard would it be to add to the download page?

Pretty easy from what I see. If plugin CSS was also minified, then this is the only line that has to be changed.

@RunDevelopment
Copy link
Member

I'll close this now in favor of #3073.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants