Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blacklist call to input() #662

Merged
merged 1 commit into from Dec 9, 2020
Merged

Remove blacklist call to input() #662

merged 1 commit into from Dec 9, 2020

Conversation

ericwb
Copy link
Member

@ericwb ericwb commented Dec 9, 2020

Now that bandit 1.6.3 is Python 3.x only, there is no longer a
need to check for a Python 2.x security issue. Namely, input()
is considered safe in Python 3.x.

Fixes #596

Signed-off-by: Eric Brown browne@vmware.com

@ericwb ericwb added this to the Release 1.6.4 milestone Dec 9, 2020
Now that bandit 1.6.3 is Python 3.x only, there is no longer a
need to check for a Python 2.x security issue. Namely, input()
is considered safe in Python 3.x.

Fixes #596

Signed-off-by: Eric Brown <browne@vmware.com>
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukehinds lukehinds merged commit 8295ded into PyCQA:master Dec 9, 2020
@ericwb ericwb modified the milestones: Release 1.6.4, Release 1.7.0 Dec 13, 2020
@bobwhitelock
Copy link

Not a big issue, but just to note: this change is backwards incompatible, we were running bandit -s B322 in our CI, and when we switched to the latest bandit this started failing with an error like this: [main] ERROR Unknown test found in profile: B322. Easily fixed once we found this issue, just thought I'd mention it in case this was unintentional and since this could impact other projects.

m-vdb added a commit to RasaHQ/rasa that referenced this pull request Dec 17, 2020
@ericwb ericwb mentioned this pull request Dec 20, 2020
kysrpex added a commit to simphony/simphony-osp that referenced this pull request Feb 18, 2021
…r it, therefore it no longer exists. See Bandit issue PyCQA/bandit#662 .
@ericwb ericwb deleted the input branch June 29, 2021 03:13
mikespallino pushed a commit to mikespallino/bandit that referenced this pull request Aug 25, 2021
Now that bandit 1.6.3 is Python 3.x only, there is no longer a
need to check for a Python 2.x security issue. Namely, input()
is considered safe in Python 3.x.

Fixes PyCQA#596

Signed-off-by: Eric Brown <browne@vmware.com>
mikespallino pushed a commit to mikespallino/bandit that referenced this pull request Jan 7, 2022
Now that bandit 1.6.3 is Python 3.x only, there is no longer a
need to check for a Python 2.x security issue. Namely, input()
is considered safe in Python 3.x.

Fixes PyCQA#596

Signed-off-by: Eric Brown <browne@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input() should not be detected as an issue in Python 3
3 participants