fix(qwik-city): Removed artificial recursive limiter from recursive path matching #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op when gets to the end
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
gnemanja
changed the title
gnemanja
changed the title
PatrickJS
added
the
STATUS-2: PR waiting for review
PatrickJS
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
For recursive matching of catchall routes, there was an artificial recursion watchdog limiter (set to 5). So, a route like
/[...catchall]/a/b/c/d/e wouldn't work if catchall didn't have a value (for example: /a/b/c/d/e would fail).
To fix this, we just check if there are any chances for the route to still match instead of stopping at the X amount of time.
Checklist: