Fix 6783 patched binds v2 #6797
Conversation
|
I think this version highlights that this is not really a reasonable change. I mean, this is literally saying "don't call |
|
I shared my opinion in original issue already, I'm still bit failed to understand if there's reason rxjs should provide its core implementation for the cases of user / application breaks spec behavior of javascript itself. I know we can, but reason why is not I'm fully getting yet. |
|
I explained the WHY here: #6783 (comment) |
There was a problem hiding this comment.
Having read the detailed use case in this comment, I'm in favour of this version of the change. However, I think it would benefit from a having a comment added explaining that Function.prototype.bind is used directly for compatibility with Monio. Maybe a link to Kyle's comment?
Apparently, code exists in the wild that will patch function bind to do something other than return a function that will execute the function instance, so we cannot rely on bind. Resolves ReactiveX#6783
benlesh
force-pushed
the
fix-6783-patched-binds-v2
branch
from
aeb2689
to
d21177f
Compare
This just has an alternative approach to #6796 ..
So we can choose.