Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6783 patched binds v2 #6797

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Fix 6783 patched binds v2 #6797

merged 5 commits into from
Feb 8, 2022

Commits on Feb 8, 2022

  1. fix(subscribe): allows functions where bind has been patched to be weird 

    Apparently, code exists in the wild that will patch function bind to do something other than return a function that will execute the function instance, so we cannot rely on bind.

Resolves ReactiveX#6783
    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    af32e48 View commit details
    Browse the repository at this point in the history

  2. refactor: Alternative bind approach

    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    c424d35 View commit details
    Browse the repository at this point in the history

  3. chore: update side-effects golden files.

    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    92c5e97 View commit details
    Browse the repository at this point in the history

  4. chore: Add comment about why bind is captured

    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    d21177f View commit details
    Browse the repository at this point in the history

  5. chore: update side-effect files again

    @benlesh
    benlesh committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    a9dd39e View commit details
    Browse the repository at this point in the history