[workspace] Add dependency on bazelbuild/platforms #18250
Conversation
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@EricCousineau-TRI for both reviews per schedule (tomorrow), please. |
Bazel 6.0 will remove the built-in copy, requiring users to BYO.
jwnimmer-tri
force-pushed
the
bazel-platforms
branch
from
b636896
to
388b98c
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/workspace/dreal/repository.bzl line 19 at r1 (raw file):
patches = [ ":patches/ibex_2.8.6.patch", ":patches/platforms.patch",
nit Should this be tracked by upstream PR?
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI)
tools/workspace/dreal/repository.bzl line 19 at r1 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
nit Should this be tracked by upstream PR?
We'll see, I might submit it a patch out of generosity (it's a larger patch when applied to dReal itself).
For Drake purposes, though dReal is deprecated and will be removed 2023-02-01 so I wasn't too concerned for us to try to get it up-streamed.
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @jwnimmer-tri)
tools/workspace/dreal/repository.bzl line 19 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
We'll see, I might submit it a patch out of generosity (it's a larger patch when applied to dReal itself).
For Drake purposes, though dReal is deprecated and will be removed 2023-02-01 so I wasn't too concerned for us to try to get it up-streamed.
Ah, makes sense - thanks for the info!
…8250) Bazel 6.0 will remove the built-in copy, requiring users to BYO.
Bazel 6.0 will remove the built-in copy, requiring users to BYO.
See bazelbuild/bazel#8622 for details and current #18246 CI for sample failure.
This change is