feat: Adding Controller Extension only on async views in Adp projects #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDamyanov
added
preview-middleware
🦋 Changeset detectedLatest commit: fb1f5f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…pps-with-sync-views
nikmace
requested changes
May 7, 2024
…pps-with-sync-views
nikmace
approved these changes
May 8, 2024
voicis
approved these changes
May 10, 2024
There was a problem hiding this comment.
- Code changes looks good
- Changeset present
- Good test coverage
- Did not test manually
If we need to add more dialogs in the future, we should look into how to better handle that logic, because it is slowly starting to get out of hand.
Also if we get more user facing texts coming from the preview middleware client, we should start using i18n mechanisms there as well.
…pps-with-sync-views
…pps-with-sync-views
…pps-with-sync-views
|
GDamyanov
deleted the
feat/1869/disable-controller-extension-for-apps-with-sync-views
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat for #1869