fix: addToCart takes actual product code into account #18731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not referring to unit under test
Platonn
reviewed
Apr 29, 2024
feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog-event.listener.ts
Show resolved
Hide resolved
…rtacus into fix/CXSPA-6791-addToCart
Platonn
reviewed
May 6, 2024
feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog-event.listener.ts
Outdated
Show resolved
Hide resolved
Comment on lines
50
to
51
| * Was the product added to the cart merged into an existing cart entry (with increased quantity), | ||
| * or did the system create a new cart entry? |
There was a problem hiding this comment.
nitpick: The question mark in the end of the sentence is a bit confusing. What about:
Suggested change
| * Was the product added to the cart merged into an existing cart entry (with increased quantity), | |
| * or did the system create a new cart entry? | |
| * Tells whether the product added to the cart was merged into an existing cart entry (with increased quantity), | |
| * or the system created a new cart entry. |
| @@ -72,6 +72,7 @@ export class CartAddEntrySuccessEvent extends CartEvent { | |||
| entry?: OrderEntry; | |||
| quantityAdded?: number; | |||
| deliveryModeChanged?: boolean; | |||
| pickupStore?: string; | |||
There was a problem hiding this comment.
Is this change really related to this PR?
There was a problem hiding this comment.
It is related (because we need to display the pickup store name in the confirmation dialogue).
But still this is a good hint, on a second look I saw that this information can also be derived from the cart modification via entry.deliveryPointOfService.name, then the event does not need to be touched!
| @@ -43,6 +43,12 @@ export interface FeatureTogglesInterface { | |||
| */ | |||
| productConfiguratorAttributeTypesV2?: boolean; | |||
|
|
|||
| /** | |||
| * The addedToCart dialog is driven by 'CartAddEntrySuccessEvent'. Previously it was driven | |||
| * by 'CartUiEventAddToCart event. Code changes affect 'AddedToCartDialogEventListener' | |||
There was a problem hiding this comment.
Suggested change
| * by 'CartUiEventAddToCart event. Code changes affect 'AddedToCartDialogEventListener' | |
| * by 'CartUiEventAddToCart' event. Code changes affect 'AddedToCartDialogEventListener' |
| protected calculateEntryWasMerged( | ||
| successEvent: CartAddEntrySuccessEvent | ||
| ): boolean { | ||
| // In case quantityAdded zero, the system could have run into stock issues. |
There was a problem hiding this comment.
From unit tests and implementation I understood that in case of stock issues the property quantityAdded is undefined (not 0).
So what about updating the comment:
Suggested change
| // In case quantityAdded zero, the system could have run into stock issues. | |
| // In case `quantityAdded` is `undefined`, the system could have run into stock issues. |
Btw. IMHO we could turn this inline comment in to a fully-fledged JSDoc of this method.
4 flaky tests on run #43499 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Checkout flow > Desktop > should checkout with a registered user |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #18731 ↗︎
Platonn
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.