Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: addToCart takes actual product code into account #18731

Merged
merged 24 commits into from
May 7, 2024
Merged

fix: addToCart takes actual product code into account #18731

merged 24 commits into from
May 7, 2024

Commits on Apr 16, 2024

  1. fix: addToCart takes actual product code into account

    @ChristophHi
    ChristophHi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    6770861 View commit details
    Browse the repository at this point in the history

  2. Remove assertion 

    Not referring to unit under test
    @ChristophHi
    ChristophHi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5437a28 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Introduce assertion that reflects the initial one

    @ChristophHi
    ChristophHi committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c893f2a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e7d927b View commit details
    Browse the repository at this point in the history

  2. Introduce toggle and base addedToCart on success event only

    @ChristophHi
    ChristophHi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    cdaf570 View commit details
    Browse the repository at this point in the history

  3. Fix pickupStore name

    @ChristophHi
    ChristophHi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3b68cea View commit details
    Browse the repository at this point in the history

  4. Add JSDoc

    @ChristophHi
    ChristophHi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d8edb1b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    029265e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Resolve conflicts

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    832b0f8 View commit details
    Browse the repository at this point in the history

  2. Review feedback: Let multiCartService determine existing entries

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6cf65cc View commit details
    Browse the repository at this point in the history

  3. Revert unintended formattingchanges

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    29a928a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    923d029 View commit details
    Browse the repository at this point in the history

  5. Tell merge state from OCC response

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    227b42e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix/CXSPA-6791-addToCart' of https://github.com/SAP/spa… 

    …rtacus into fix/CXSPA-6791-addToCart
    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    654de28 View commit details
    Browse the repository at this point in the history

  7. Remove non-intended files

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6c69495 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c06ee32 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Improve JS doc, added further deprecations

    @ChristophHi
    ChristophHi committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7a40936 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0b2aa9e View commit details
    Browse the repository at this point in the history

  3. Improve test descriptions

    @ChristophHi
    ChristophHi committed May 2, 2024
    Configuration menu
    Copy the full SHA
    687a8fa View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ee04c39 View commit details
    Browse the repository at this point in the history

  2. fix sonar issue

    @ChristophHi
    ChristophHi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f07a8e2 View commit details
    Browse the repository at this point in the history

  3. Trigger Build

    @ChristophHi
    ChristophHi committed May 6, 2024
    Configuration menu
    Copy the full SHA
    df081b5 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Review feedback II + take pickup name from response

    @ChristophHi
    ChristophHi committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fbd7719 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/CXSPA-6791-addToCart

    @ChristophHi
    ChristophHi committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a9e599f View commit details
    Browse the repository at this point in the history