[DO NOT MERGE] CXSPA-6939 (PoC) Handling breaking changes related to SSR Error Handling #18789
+166
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
reviewed
May 6, 2024
projects/core/src/error-handling/effects-error-handler/cx-error-handler.effect.ts
Outdated
Show resolved
Hide resolved
| @@ -24,6 +23,7 @@ import { StateModule } from './state/state.module'; | |||
|
|
|||
| @NgModule({ | |||
| imports: [ | |||
| // breaking change - HttpErrorHandlerInterceptor may have featureService inside manipulate the behavior (implemented) OR we can inform in docs that this module has to be imported | |||
There was a problem hiding this comment.
FeatureToggles for the win. It's easy, simple, documented.
Importing extra modules by customers is an extra overhead. It should be required only in cases when bundlesize of importing this module by default would be considerable.
Comment on lines
+35
to
+37
| // possible ways of handling breaking changes in ALL actions: | ||
| // - introduce CustomerSearchFailV2 and deprecate old class | ||
| // - overload the constructor of CustomerSearchFail and handle the change there together with deprecating he old one |
There was a problem hiding this comment.
I'm sorry. I don't get the problem - what a breaking change we have? TS Type? Behavior?
And how we're mitigating it?
And if introducing any temporary solutions (e.g. deprecated things), when will we remove them?
There was a problem hiding this comment.
As we discussed, usage of a new type in the constructor or making the constructor's params required provide breaking changes.
Action points for such cases:
- revert usage of new
ErrorActionTypetype - overload the constructor and deprecate the deprecate version with the optional
error/payloadparam - create a fallback if the error passed to the constructor is
undefined(assignnew Error)
…ing-breaking-changes
pawelfras
force-pushed
the
feat/CXSPA-6939-poc-handling-breaking-changes
branch
from
80b3e47
to
8e05980
Compare
pawelfras
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains PoC on how to handle breaking changes introduced by features required for SSR Error Handling: