Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customProptypes): add a check for Element existance #3965

Merged
merged 2 commits into from Jun 23, 2020

Conversation

layershifter
Copy link
Member

Fixes #3864.

The fix is a similar to reactjs/react-transition-group#619 and will stop warnings for SSR envs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #3965 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3965   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      178           
  Lines        3150     3150           
=======================================
  Hits         3145     3145           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478af65...7ae8fe3. Read the comment docs.

@layershifter layershifter reopened this Jun 23, 2020
@layershifter layershifter merged commit e71b0a1 into master Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/proptypes-ssr branch June 23, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar gives proptype error
2 participants