Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(customProptypes): add a check for Element existance #3965

Merged
merged 2 commits into from Jun 23, 2020
Merged

fix(customProptypes): add a check for Element existance #3965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c77c9
fix(customProptypes): add a check for Element existance
layershifter Jun 23, 2020
7ae8fe3
Merge branch 'master' into fix/proptypes-ssr
layershifter Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib/customPropTypes.js
View file
Open in desktop
Expand Up @@ -10,6 +10,8 @@ const typeOf = (...args) => Object.prototype.toString.call(...args)
export const domNode = (props, propName) => {
// skip if prop is undefined
if (props[propName] === undefined) return
// short circle for SSR env
if (typeof Element === 'undefined') return
// skip if prop is valid
if (props[propName] instanceof Element) return

Expand Down