New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Polaris StrictMode compliant #785
Comments
Also related: #519 is an issue to track the removal of deprecated lifecycle hooks |
Hi @jineshshah36 , as Ben mentioned we're currently in the process of removing deprecated lifecycle hooks as tracked in #519. We don't have an issue tracking the switch to the new context api, but we've already begun using the new context api in a few components and will be switching more in the future. |
I'm getting a 500 error when I try to visit #519, but that is good to hear |
Issue summary
Currently, there are many components that are not StrictMode compliant within Polaris because they using the legacy context API or use deprecated lifecycle methods. Given that React 16.7 will support a concurrent mode which should hopefully improve application performance for most situations, it would be great if Polaris because StrictMode compliant so that we could use it in the future without issue.
Expected behavior
Polaris should be StrictMode compliant
Actual behavior
Polaris is not StrictMode compliant
Steps to reproduce the problem
Reduced test case
N/A
Specifications
N/A
The text was updated successfully, but these errors were encountered: