Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0.0 #902

Merged
merged 263 commits into from Aug 7, 2019
Merged

Version 4.0.0 #902

merged 263 commits into from Aug 7, 2019

Conversation

danrosenthal
Copy link
Contributor

No description provided.

@danrosenthal danrosenthal added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Jan 18, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-902 January 18, 2019 16:30 Inactive
@BPScott
Copy link
Member

BPScott commented Feb 6, 2019

Things I'd like to see (a non-exhaustive list):

Code tidying:

  • Migrate legacy context API usage to the modern version (this PR starts on this already)
  • Remove the dependency on prop-types (it looks like moving to the new context API removes most of our existing needs for this).
  • Migrate usage of deprecated lifecycle hooks (this can be done in 3.x releases) - Avoid using deprecated/UNSAFE_* React methods #519
  • Strict mode compliance and some way to assert this in tests/storybook (I think the removal of legacy context and deprecated lifecycle hooks are prerequisites for this) - Make Polaris StrictMode compliant #785
  • Update minimum version of react/react-dom to at least 16.8 so that we can use hooks.
  • Write a withAppProvider hook and use it in place of the withAppProvider() higher-order-component. This ensures means that every component can be a function/class instead of a potentially being wrapped in a HoC. This also means we don't have to do annoying stuff with ComposedProps when building a component. We should probably leave the HoC in place for the release eve if we don't use it internally to give people who consume polaris and may be using it an easier update path

More speculative build stuff:


Whilst "use hooks for ALL THE THINGS" is a laudable goal, and probably where we want to get to eventually, rewriting without adding value probably isn't the best use of time. I think opening the door for using hooks in v4.0.0 is a solid start, and then we can migrate to hooks on a per-component basis in minor releases

@BPScott BPScott added this to the v4.0.0 milestone Apr 30, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-902 August 5, 2019 18:33 Inactive
[v4] Update frame utilities & associated components
@BPScott BPScott temporarily deployed to polaris-react-pr-902 August 6, 2019 15:19 Inactive
@tmlayton
Copy link
Contributor

tmlayton commented Aug 6, 2019

Would love to see us get over the 90% coverage target

@BPScott BPScott temporarily deployed to polaris-react-pr-902 August 6, 2019 19:42 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-902 August 6, 2019 21:00 Inactive
@AndrewMusgrave
Copy link
Member

@tmlayton 😎

@BPScott BPScott temporarily deployed to polaris-react-pr-902 August 7, 2019 15:14 Inactive
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going through all of the files, but I have tophatted the changes in styleguide. Looks good to me.

@danrosenthal
Copy link
Contributor Author

I can't approve my own PR, but consider this my ✅. Nice work, @AndrewMusgrave and @BPScott!

@BPScott BPScott requested a deployment to polaris-react-pr-902 August 7, 2019 16:25 Abandoned
@AndrewMusgrave AndrewMusgrave added 🤖Skip Changelog Causes CI to ignore changelog update check. and removed 🤖Skip Changelog Causes CI to ignore changelog update check. labels Aug 7, 2019
@AndrewMusgrave AndrewMusgrave merged commit 7e4e9e8 into master Aug 7, 2019
@AndrewMusgrave AndrewMusgrave temporarily deployed to production August 13, 2019 21:12 Inactive
@BPScott BPScott deleted the version-4.0.0 branch December 17, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants