New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.0.0 #902
Version 4.0.0 #902
Conversation
Things I'd like to see (a non-exhaustive list): Code tidying:
More speculative build stuff:
Whilst "use hooks for ALL THE THINGS" is a laudable goal, and probably where we want to get to eventually, rewriting without adding value probably isn't the best use of time. I think opening the door for using hooks in v4.0.0 is a solid start, and then we can migrate to hooks on a per-component basis in minor releases |
Update v4 19/03/21
Add test
[AppProvider] Remove componentWillReceiveProps
[ThemeProvider] Remove componentWillReceiveProps
[Scrollable] Update context api
[AutoComplete] Use new context api
[Navigation] Use new context api
[v4] Update frame utilities & associated components
Would love to see us get over the 90% coverage target |
[v4] Minor changes to bump test coverage slightly
[v4][Collapsible] Polish - resize bug/test
[v4] Merge master into v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not going through all of the files, but I have tophatted the changes in styleguide. Looks good to me.
I can't approve my own PR, but consider this my ✅. Nice work, @AndrewMusgrave and @BPScott! |
Remove unused spread operator
No description provided.