[v4] Update no unsafe eslint rule #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
update-no-unsafe
branch
from
c676dc7
to
39e24f8
Compare
|
I snuck this into eslint-plugin-shopify the other day Shopify/eslint-plugin-shopify#302. Matt's already cut a v29.0.0 with that change in it, and is in the process of putting it into sewing-kit. I'd be tempted to wait ill new version of SK is released with that in, and then we get this rule as part of a sewing-kit update. |
BPScott
approved these changes
Jun 17, 2019
|
Since you approved this pr, I'll merge this in for now. But create an issue to check for a |
AndrewMusgrave
added
the
馃Skip Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We removed the last deprecated lifecycle method 馃帀 I was going to add strict mode to storybook but it looks like we use ReactDOM.findDOMNode which is also a nono for strict mode, and will need to be handled but should be an easy fix.