Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Update no unsafe eslint rule #1695

Merged
merged 2 commits into from Jun 18, 2019
Merged

[v4] Update no unsafe eslint rule #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bcdf00
Enable no-unsafe with checkAliases
AndrewMusgrave Jun 17, 2019
39e24f8
changelog
AndrewMusgrave Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@
"react/button-has-type": "off",
"react/no-array-index-key": "off",
"react/jsx-fragments": ["error", "element"],
"react/no-unsafe": ["error", {"checkAliases": true}],
"shopify/jsx-no-complex-expressions": "off",
"shopify/jsx-prefer-fragment-wrappers": "off",
"shopify/no-ancestor-directory-import": "error",
Expand Down
1 change: 1 addition & 0 deletions UNRELEASED-V4.md
View file
Open in desktop
Expand Up @@ -44,6 +44,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Code quality

- Enabled react/no-unsafe with checkAliases ([#1695](https://github.com/Shopify/polaris-react/pull/1695))
- Added hooks to storybooks scope ([#1672](https://github.com/Shopify/polaris-react/pull/1672))
- Simplified `WithinContentContainer` context type ([#1602](https://github.com/Shopify/polaris-react/pull/1602))
- Updated `Collapsible` to no longer use `componentWillReceiveProps`([#1670](https://github.com/Shopify/polaris-react/pull/1670))
Expand Down