Bump eslint plugins #179
Bump eslint plugins #179
Conversation
Preps for the latest major version of TS tooling, and sets the stage for ESLint 7 updates, supporting optional-chaining Major bumps are: - @typescript-eslint/eslint-plugin to 4.1.0 - eslint-plugin-graphql to 4.0.0 - eslint-plugin-jest to 24.0.0
| 'error', | ||
| {ignoreRhs: true}, | ||
| ], | ||
| '@typescript-eslint/no-unnecessary-condition': ['error'], |
There was a problem hiding this comment.
The ignoreRhs was removed
| @@ -44,7 +44,7 @@ module.exports = { | |||
| // Disallow setup and teardown hooks | |||
| 'jest/no-hooks': 'off', | |||
| // Using a callback in asynchronous tests | |||
| 'jest/no-test-callback': 'error', | |||
| 'jest/no-done-callback': 'error', | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
jest/no-try-expect is deprecated in favor of jest/no-conditional-expect
There was a problem hiding this comment.
Should we add those new rules
jest/no-interpolation-in-snapshotsjest/no-deprecated-functions
There was a problem hiding this comment.
They seem reasonable, good spot
| "eslint-plugin-graphql": "3.1.1", | ||
| "eslint-plugin-babel": "5.3.1", | ||
| "eslint-plugin-eslint-comments": "3.2.0", | ||
| "eslint-plugin-graphql": "4.0.0", |
There was a problem hiding this comment.
Just double-checking, this version only supports Node.js 10.
There was a problem hiding this comment.
This plugin only supports node 10 since we moved to typescript-eslint/eslint-plugin v3 (which dropped support for node 8) so this doesn't affect our version support :)
|
https://github.com/Shopify/web/pull/31363 is a web PR that contains these changes. The lint report is at https://buildkite.com/shopify/web-ci-builder/builds/244536#b110f57c-5714-43d6-97c1-5c04a6b2de1f 444 new linting errors are introduced.
|
Fixed: #161
Preps for the latest major version of TS tooling, and sets the stage for
ESLint 7 updates, supporting optional-chaining
Major bumps are: