New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint plugins #179
Bump eslint plugins #179
Changes from all commits
af1e693
544f7b0
22ce623
c7fdff1
681616d
35f5f2c
889c25b
b4a1449
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,10 +34,7 @@ module.exports = { | |
// When adding two variables, operands must both be of type number or of type string | ||
'@typescript-eslint/restrict-plus-operands': 'error', | ||
// Prevents conditionals where the type is always truthy or always falsy | ||
'@typescript-eslint/no-unnecessary-condition': [ | ||
'error', | ||
{ignoreRhs: true}, | ||
], | ||
'@typescript-eslint/no-unnecessary-condition': ['error'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
// Warns if an explicitly specified type argument is the default for that type parameter | ||
'@typescript-eslint/no-unnecessary-type-arguments': 'error', | ||
// Requires that private members are marked as readonly if they're never modified outside of the constructor | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@shopify/eslint-plugin", | ||
"version": "38.0.0", | ||
"version": "38.1.0-beta.3", | ||
"license": "MIT", | ||
"description": "Shopify’s ESLint rules and configs.", | ||
"keywords": [ | ||
|
@@ -33,26 +33,26 @@ | |
"eslint": "^6.0.0" | ||
}, | ||
"dependencies": { | ||
"@typescript-eslint/eslint-plugin": "^3.9.1", | ||
"@typescript-eslint/parser": "^3.9.1", | ||
"@typescript-eslint/eslint-plugin": "^4.1.0", | ||
"@typescript-eslint/parser": "^4.1.0", | ||
"babel-eslint": "10.1.0", | ||
"change-case": "^4.1.1", | ||
"common-tags": "^1.8.0", | ||
"eslint-config-prettier": "6.11.0", | ||
"eslint-module-utils": "2.6.0", | ||
"eslint-plugin-babel": "5.3.0", | ||
"eslint-plugin-eslint-comments": "3.1.2", | ||
"eslint-plugin-graphql": "3.1.1", | ||
"eslint-plugin-babel": "5.3.1", | ||
"eslint-plugin-eslint-comments": "3.2.0", | ||
"eslint-plugin-graphql": "4.0.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just double-checking, this version only supports Node.js 10. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This plugin only supports node 10 since we moved to typescript-eslint/eslint-plugin v3 (which dropped support for node 8) so this doesn't affect our version support :) |
||
"eslint-plugin-import": "2.22.0", | ||
"eslint-plugin-jest": "23.13.0", | ||
"eslint-plugin-jest": "24.0.0", | ||
"eslint-plugin-jest-formatting": "2.0.0", | ||
"eslint-plugin-jsx-a11y": "6.2.3", | ||
"eslint-plugin-jsx-a11y": "6.3.1", | ||
"eslint-plugin-node": "11.1.0", | ||
"eslint-plugin-prettier": "3.1.3", | ||
"eslint-plugin-prettier": "3.1.4", | ||
"eslint-plugin-promise": "4.2.1", | ||
"eslint-plugin-react": "7.20.0", | ||
"eslint-plugin-react-hooks": "4.0.2", | ||
"eslint-plugin-sort-class-members": "1.7.0", | ||
"eslint-plugin-react": "7.20.6", | ||
"eslint-plugin-react-hooks": "4.1.1", | ||
"eslint-plugin-sort-class-members": "1.8.0", | ||
"merge": "^1.2.1", | ||
"pkg-dir": "^4.2.0", | ||
"pluralize": "^8.0.0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jest-community/eslint-plugin-jest#653
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jest/no-try-expect
is deprecated in favor ofjest/no-conditional-expect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add those new rules
jest/no-interpolation-in-snapshots
jest/no-deprecated-functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem reasonable, good spot