Support NPM 9.0.0 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sert the .bin location in relation to it
dominicfraser
commented
Mar 17, 2023
| @@ -79,7 +79,8 @@ const checkVersion = (engineName, command) => { | |||
| let localVersionValid = null; | |||
|
|
|||
| try { | |||
| const localBinFolder = execSync('npm bin').toString().trim(); | |||
| const localRootFolder = execSync('npm root').toString().trim(); | |||
There was a problem hiding this comment.
The previous output would have been like:
/Users/dominicfraser/Documents/repos/my-repo/packages/common/node_modules/.bin'
The new output would be like
/Users/dominicfraser/Documents/repos/my-repo/packages/common/node_modules'
We take this then prepend /.bin below.
There was a problem hiding this comment.
This has been tested on NPM 8 and NPM 9, on local machine and in our CI.
jbard1
approved these changes
Mar 20, 2023
olliecurtis
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18.14.0 Docker images come paired with NPM 9.3.0 - the first update that brings in NPM v9.
Node + NPM pairings can be seen at: https://nodejs.org/dist/index.json
NPM 9.0.0 removes the
npm bincommand, that this repo is relying on.The NPM release can be see at: https://github.com/npm/cli/releases/tag/v9.0.0
This PR works around this removal by switching to
npm rootand prepending/.bin.npm rootis also available in older versions of NPM.https://docs.npmjs.com/cli/v9/commands/npm-root?v=true
https://docs.npmjs.com/cli/v8/commands/npm-bin?v=true