Update typescript-eslint to 2.6.0 #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
force-pushed
the
upgrade-typescript-eslint-2
branch
from
513e564
to
0499c2f
Compare
vilchik-elena
changed the title
yassin-kammoun-sonarsource
approved these changes
Oct 28, 2019
vilchik-elena
changed the title
saberduck
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
prefer-readonly) looks like issues with properties of array or object type are excluded now, it's hard to identify due to which change (may be transitive dep change)no-inferrable-types), FPs removed, see fix(eslint-plugin): [no-inferrable-types] ignore optional properties typescript-eslint/typescript-eslint#918We failed to update to latest 2.5.0 version as unit tests on Windows are failing. It's unclear due to which reason, we are postponing this investigation.
Still looks like updating to 2.6.0 works. I only needed to change TS version compatibility (see typescript-eslint/typescript-eslint#1121)