Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cecil to 0.11.2 #1617

Merged
merged 1 commit into from May 15, 2020
Merged

Conversation

dennisameling
Copy link
Contributor

Closes #1616

@JayBeavers
Copy link

FYI, this PR unblocks GitHub Desktop for Surface Pro X and VSCode for Surface Pro X. Looking forward excitedly to this minor change being committed!

@dennisameling
Copy link
Contributor Author

If the team considers the upgrade from 0.9.6.1 to 0.11.2 "too risky", it is also possible to upgrade to 0.10 as it seems to be included in that version already.

@anaisbetts anaisbetts merged commit ecaeb93 into Squirrel:develop May 15, 2020
@anaisbetts
Copy link
Contributor

@JayBeavers I'm so confused, VS Code rejected Squirrel.Windows long long ago, are you saying they switched back to it?

@dennisameling dennisameling deleted the update-cecil branch May 15, 2020 08:00
@JayBeavers
Copy link

Pardon, I may have gotten confused by the cross-project discussion between similar needs of Github Desktop and VS Code. I went and looked back at the arm64 support threads for VSCode and I don't see the mention of the squirrel dependency.

Just an overeager dev who loves his Surface Pro X and wants native binaries for core tools :-)

@JayBeavers
Copy link

Ah, I see. desktop/desktop#9691 was linked to the thread on supporting arm64 with VSCode (microsoft/vscode#33620)
and I didn't pick up from the UI that this was a work item on github desktop, not on vscode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Squirrel installer crashes on Windows 10 ARM64 (Cecil update required)
3 participants