New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scheduleGarbageCollection): Do not garbage collect newly cached queries of the same hash #332
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5c75a8e
Add manual/prefetch cleanup test that fails
kamranayub 3d1aa7a
Prefetch both queries in second test
kamranayub aa44aa9
Add cleanup comment that will make the tests pass
kamranayub e30cf94
Store when the GC was initiated and compare against updatedAt
kamranayub 5835d22
Replace solution with state marker check and streamline test
kamranayub 6976cb3
Undo setting.json change
kamranayub 7dbb61a
Undo setting.json change
kamranayub File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,19 @@ | ||
{ | ||
"workbench.colorCustomizations": { | ||
"titleBar.activeBackground": "#ff4154", // change this color! | ||
"titleBar.inactiveBackground": "#ff4154", // change this color! | ||
"titleBar.activeForeground": "#ffffff", // change this color! | ||
"titleBar.inactiveForeground": "#ffffff" // change this color! | ||
} | ||
"activityBar.background": "#ff7482", | ||
"activityBar.activeBackground": "#ff7482", | ||
"activityBar.activeBorder": "#70ff60", | ||
"activityBar.foreground": "#15202b", | ||
"activityBar.inactiveForeground": "#15202b99", | ||
"activityBarBadge.background": "#70ff60", | ||
"activityBarBadge.foreground": "#15202b", | ||
"titleBar.activeBackground": "#ff4154", | ||
"titleBar.inactiveBackground": "#ff415499", | ||
"titleBar.activeForeground": "#e7e7e7", | ||
"titleBar.inactiveForeground": "#e7e7e799", | ||
"statusBar.background": "#ff4154", | ||
"statusBarItem.hoverBackground": "#ff7482", | ||
"statusBar.foreground": "#e7e7e7" | ||
}, | ||
"peacock.color": "#ff4154" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is called automatically by RTL?