ci: test cross platform

[ChristianMurphy]

Test on Node.js 10 and 12, long term release support versions.
Test on Linux, Mac, and Windows machines.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 99fe42c:

Sandbox	Source
wild-wind-hih9r	Configuration

[tannerlinsley]

I'm not sure why this is failing. Can anyone tell?

[stramel]

@tannerlinsley Looks like is-ci-cli may have an issue with Windows?

[ChristianMurphy]

As far as I can tell, is-ci-cli has an issue where it is unable to detect travis ci for windows as a CI environment.
I've logged this upstream as watson/is-ci#19

I could revert the windows part and keep the MacOS and Linux part for now to unblock this, if folks prefer.

[tannerlinsley]

👍 Tanner Linsley

…

On Oct 4, 2019, 11:00 AM -0600, Christian Murphy ***@***.***>, wrote: As far as I can tell, is-ci-cli has an issue where it is unable to detect travis ci for windows as a CI environment. I've logged this upstream as watson/is-ci#19 I could revert the windows part and keep the MacOS and Linux part for now to unblock this, if folks prefer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[stramel]

I don't see how it wouldn't be detecting the TravisCI as a CI environment. is-ci-cli uses is-ci which uses ci-info of which everything seems correct. Including your PR passing on Windows for is-ci. If is-ci-cli was failing to detect the CI environment, it should fallback to running test:dev script.

I put out a PR on is-ci-cli to use cross-spawn and throw any errors that try to silently fail. Hopefully this will catch it. YellowKirby/is-ci-cli#5

In the meantime, @ChristianMurphy you could try pointing to my fork and branch to see if it fixes it.

[stramel]

@ChristianMurphy Can you try v2.0.0 of is-ci-cli?

[ChristianMurphy]

Thanks @stramel, updated to is-ci-cli version 2

[ChristianMurphy]

Closing this in favor of #1578
The issue doesn't appear on GitHub actions CI workflow or in local testing.
I suspect the issue may with with Travis CI Windows beta issue.

[stramel]

@ChristianMurphy You can fix the issue by adding this to the .travis.yml

env:
  global:
    - YARN_GPG=no

[stramel]

@ChristianMurphy I wrote out a travis file for the is-ci-cli lib. That's how I knew what worked :P https://github.com/YellowKirby/is-ci-cli/pull/6/files

https://travis-ci.org/stramel/is-ci-cli/builds/595780320

[stramel]

@ChristianMurphy You might want to try removing the quotes around the script. I think that is causing windows to fail.

[stramel]

Just wanted to note, that it's generally bad practice to have both package-lock.json and yarn.lock

[tannerlinsley]

I agree. I'm not even sure how the package-lock.json got in there TBH